Andrew Donnellan <a...@linux.ibm.com> writes: > It's not valid to put a <div> inside an <h1>. Move the download buttons in > the submission template outside the <h1> tag.
Two things: 1) This makes the buttons float up out of line with the title. The floating up isn't the end of the world as there's probably too much whitespace between the navbar and the tile, but I would like the visual consistency to remain. 2) With a long title and with the buttons in the <h1>, the buttons appear below the text. With the buttons outside the <h1> they'll stay at the top right hand corner and the title is wrapped around the buttons. I actually think this is better, it keeps the buttons in a more predictable spot. If you can fix (1) and keep (2) that'd be great, but the important thing would be to fix (1). I think you can do that by putting the title and the buttons in a <div>, but I haven't checked. Regards, Daniel > > Signed-off-by: Andrew Donnellan <a...@linux.ibm.com> > --- > patchwork/templates/patchwork/submission.html | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/patchwork/templates/patchwork/submission.html > b/patchwork/templates/patchwork/submission.html > index b5b55dbd9241..407f9ece85fb 100644 > --- a/patchwork/templates/patchwork/submission.html > +++ b/patchwork/templates/patchwork/submission.html > @@ -27,9 +27,8 @@ function toggle_div(link_id, headers_id) > } > </script> > > -<h1>{{ submission.name }} > {% include "patchwork/partials/download-buttons.html" %} > -</h1> > +<h1>{{ submission.name }}</h1> > > <table class="patchmeta"> > <tr> > @@ -273,10 +272,8 @@ function toggle_div(link_id, headers_id) > {% endfor %} > > {% if submission.diff %} > -<h2> > - Patch > - {% include "patchwork/partials/download-buttons.html" %} > -</h2> > +{% include "patchwork/partials/download-buttons.html" %} > +<h2>Patch</h2> > > <div id="patch" class="patch"> > <pre class="content"> > -- > 2.20.1 > > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork