Hi Sean, On Sun, 25 Oct 2020 at 19:23, Sean Anderson <sean...@gmail.com> wrote: > > On 10/25/20 9:04 PM, Simon Glass wrote: > > At present it is possible to put sign-off tags before the change log. This > > works but then it is hard for patman to add its own tags to a commit. Also > > if the commit has a Change-Id (e.g. for Gerrit) the commit becomes invalid > > if there is anything after it. > > NAK. I put SOBs before changelogs in all my series. Doing it like this > makes the pre-patman commit more-closely match what is sent to the > mailing list, and what will eventually be committed. What is most > important is the summary, the description, who has signed off, and > lastly any changelogs which will be removed by git am. > > I also like to put SOBs on top because it groups all the commit-specific > information before any patman-specific tags. The last commit (the HEAD) > usually has several tags (Series-to/cc, Series-process-log, > Cover-letter, etc.) which are unrelated to the commit itself. > > The tool should do what is best for us humans, not what is convenient > for the tool.
I suppose it can be done. But we have the same problem with Change-Id. Do you use gerit? Regards, SImon _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork