Hi, Jeffrey, Thank you for comments. I already prepared new version with the Multiplier correction.
About discriminator SUB-TLV – meaning is that is optional as S-BFD TLV is optional, but if speaker sends S-BFD TLV with B flag 1, then sub TLV is MUST. I will add it to the description. About language – I corrected many things and will publish new version in the very near future Best regards, [Logo]<https://ribboncommunications.com/> Marina Fizgeer Sr. Manager, Systems Architecture | Ribbon M +972.544860016 Petah Tikva, Israel [Banner]<https://ribboncommunications.com/?_gl=1*6qlbuc*_gcl_au*MjA3NzE5OTk5NC4xNzI4NDE0NDY4*_ga*NTIxNzg1MDgxLjE3Mjg0MTQ0NjM.*_ga_VCEZ9Q3S3Y*MTcyODQ1MjEzMC4yLjEuMTcyODQ1MjE4OS4xLjAuMTA4NjExNTU4> From: Jeffrey Haas <[email protected]> Sent: Sunday, August 17, 2025 5:17 PM To: [email protected] Cc: [email protected]; [email protected] Subject: [EXTERNAL] A few comments on draft-ietf-pce-pcep-bfd-parameters-00 §4.3.2.2 <https://datatracker.ietf.org/doc/html/draft-ietf-pce-pcep-bfd-parameters-00#section-4.3.2.2<https://datatracker.ietf.org/doc/html/draft-ietf-pce-pcep-bfd-parameters-00#section-4.3.2.2>> Multiplier: 1000..255000 This should be 1..255. §4.3.2.3 <https://datatracker.ietf.org/doc/html/draft-ietf-pce-pcep-bfd-parameters-00#section-4.3.2.3<https://datatracker.ietf.org/doc/html/draft-ietf-pce-pcep-bfd-parameters-00#section-4.3.2.3>> LSP-SBFD-Discriminator sub-TLV <https://datatracker.ietf.org/doc/html/draft-ietf-pce-pcep-bfd-parameters-00#name-lsp-sbfd-discriminator-sub-<https://datatracker.ietf.org/doc/html/draft-ietf-pce-pcep-bfd-parameters-00#name-lsp-sbfd-discriminator-sub->> Under what circumstances should this TLV be optional? S-BFD really needs you to know the discriminator in order to work. In the case where it's not present, was there another way that we're able to be signaled "S-BFD is supported, but you'll learn the discriminator somewhere else"? If so, it might be worth discussing that in the document. Aside from these two nits, the document is clear for someone not familiar with PCE. IMO, the document could do with a round of simplifying some of the text since some of the procedure feels redundantly stated. However, this might be a style choice consistent with other PCE documents and thus is only a personal preference. -- Jeff Disclaimer This e-mail together with any attachments may contain information of Ribbon Communications Inc. and its Affiliates that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.
_______________________________________________ Pce mailing list -- [email protected] To unsubscribe send an email to [email protected]
