Hello!
PCMan has written on Thursday, 13 September, at 13:19:
>Please wait for a moment and give me some time to finish my implementation.
>I'll comment on your new proposal later.
>Mine is 80% finished now and I consider it very clean.
>We can change it later if you really don't like the new implementation.
>The code is not yet pushed to git but I'll push it soon.
>The code written in GSoC 2010 by the student is not usable and has
>many problems.
>I'm rewriting this part myself now and will push the new code to git this week.
>All of the work is done in one single class, FmSearchJob, which is
>derived from FmDirListJob and that's all. Then change is totally
>backward compatible and does not affect any existing parts.
>I'll push them to git ASAP for you to review.
>I promise, there are no dirty hacks. :-)
>So please give me some time.
Thank you very much! Good to hear that. Just adding 2 cents to it.
While going to sleep I've thought about search engine and found it very
useful if search engine could be used by FmSearchJob and by future new
'search://' URI handler as well. So instead written in GSoC 2010 mode
when FmSearch uses FmSearchJob, all search engine should be in FmSearch
instead (kind of implementation g_file_enumerate_children) so FmSearchJob
will be simple job that calls FmSearch asyncronously. I mean reverse the
meaning of FmSearch which will be object with blocking operations, i.e.
move search subroutines from FmSearchJob into src/base/fm-search so its
can be reused later. Though it can be done in any moment later I think.
It will be needed to never touch any of gtk code for adding search with
exception to one mentioned API and some button to call that API. :)
Cheers!
Andriy.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Pcmanfm-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pcmanfm-develop
