OK... my suggestion would be just to try not to worry about Solaris :)
M
On Tue, Dec 18, 2012 at 06:54:29PM +0100, IOhannes m zmoelnig wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 2012-12-18 18:44, Miller Puckette wrote:
> > OK.. so how's this:
> >
> > For close I'll just edit in your sys_close hack :)
>
> good.
>
> >
> > For sys_open, let's just unconditionally say:
> >
> > int imode = va_arg (ap, int); mode=(mode_t)imode;
> >
> > without the surrounding if(sizeof(mode_t) < sizeof(int)).
>
>
> afaik, mode_t can be wider than int on some architectures
> (solaris-64bit?), which would then probably break.
> since Pd doesn't support solaris right now, we could simply not care
> about that until we actually meet an architecture that makes problems,
> and then take counteractions.
>
> the simplest solution would probably be:
> > int sys_open(const char *path, int oflag, mode_t mode) { int i,
> > fd; char pathbuf[MAXPDSTRING]; sys_bashfilename(path, pathbuf);
> > return open(pathbuf, oflag, mode); }
>
>
> fgmasdr
> IOhannes
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAlDQrdIACgkQkX2Xpv6ydvQEBwCeMAC+zvRksCo7wJa6+saQzQga
> WGUAnR67nczaIAqr0UPN+fczzY7jFtaY
> =XXB7
> -----END PGP SIGNATURE-----
_______________________________________________
Pd-dev mailing list
Pd-dev@iem.at
http://lists.puredata.info/listinfo/pd-dev
