I've rolled this into the repo as a patch which is applied by the mac/tcltk-wish.sh script. This way, you'll get this when building 8.5.19 for macOS automatically. See commit details here: https://github.com/pure-data/pure-data/pull/447/commits/923a6a249c36a42075f7c7d5ab298473a273ec94 <https://github.com/pure-data/pure-data/pull/447/commits/923a6a249c36a42075f7c7d5ab298473a273ec94>
I think it's important that these kind of things don't get lost and that it's still possible for people to get the as close as possible to the same build as the releases, especially for testing. > On Sep 12, 2018, at 4:37 AM, Miller Puckette <[email protected]> wrote: > > OK, updated TK source: > > http://msp.ucsd.edu/tmp/misc/tk8.5.19-pd49test2-src.tar.gz > > M > > On Tue, Sep 11, 2018 at 07:30:30PM -0700, Miller Puckette wrote: >> Think I found it - a careless edit on my part... in >> tk8.5.19/macosx/tkMacOSXKeyEvent.c >> the lines: >> >> case NSKeyUp: >> if (finishedCompose) >> if (!releaseCode) >> return theEvent; >> >> should be just: >> >> case NSKeyUp: >> if (!releaseCode) >> return theEvent; >> >> I'll update the source tarball and make a compiled one just so we're all on >> the >> same page. Deleting that one line has stopped the "save as" crashes for me, >> and >> might also have fixed the other current crasher. >> >> cheers >> M >> >> On Tue, Sep 11, 2018 at 06:14:45PM -0700, Miller Puckette wrote: >>> Yes, I'm running on the theory that it's my keyup patch that's doing this. >>> >>> M >>> >>> On Wed, Sep 12, 2018 at 01:26:12AM +0200, Dan Wilcox wrote: >>>> I'm seeing the same on macOS 10.13.6. This is a crash in the GUI and seems >>>> to be something to do with the Tk version as running PD with the built-in >>>> version of Tk on my system works fine. >>>> >>>>> On Sep 12, 2018, at 12:20 AM, [email protected] wrote: >>>>> >>>>> From: jakob skouborg <[email protected] >>>>> <mailto:[email protected]>> >>>>> >>>>> but I think I might have experienced a bug here on OSX 10.10.5(Yosemite): >>>>> >>>>> - When I do a ???save as??? and I type in the name in the save dialog and >>>>> then push ??? Save as??? button, PD crashed. I have not been able to save >>>>> a patch yet. >>>>> >>>>> Can anyone replicate? >>>>> >>>>> Thanks and have a great evening ;) >>>>> >>>>> Jakob(Jaffasplaffa) >>>> >>>> -------- >>>> Dan Wilcox >>>> @danomatika <http://twitter.com/danomatika> >>>> danomatika.com <http://danomatika.com/> >>>> robotcowboy.com <http://robotcowboy.com/> >>>> >>>> >>>> >>> >>>> _______________________________________________ >>>> Pd-dev mailing list >>>> [email protected] >>>> https://lists.puredata.info/listinfo/pd-dev >>> >>> >>> >>> >>> _______________________________________________ >>> Pd-dev mailing list >>> [email protected] >>> https://lists.puredata.info/listinfo/pd-dev >> >> >> >> _______________________________________________ >> Pd-dev mailing list >> [email protected] >> https://lists.puredata.info/listinfo/pd-dev -------- Dan Wilcox @danomatika <http://twitter.com/danomatika> danomatika.com <http://danomatika.com/> robotcowboy.com <http://robotcowboy.com/>
_______________________________________________ Pd-dev mailing list [email protected] https://lists.puredata.info/listinfo/pd-dev
