On 2015-05-03 15:58, Fred Jan Kraan wrote: > On 2015-05-03 03:11 PM, Alexandros Drymonitis wrote: >> >> >> On Sun, May 3, 2015 at 2:58 PM, Raphaël Ilias <phae.il...@gmail.com >> <mailto:phae.il...@gmail.com>> wrote: >> >> However, IMHO, since frequency representation is related to the time >> and not the sampling rate, I think this should be corrected in the >> object itself, maybe as Alexandros suggested. >> But I don't have the skills to do that myself... hope Günther will >> read this. >> >> I've written some externals and used this and it works fine. If you just >> change this line of code and compile the object, it should work, I >> guess... >> > It might be better to replace the 44100.0 by the proper function here like: > x->x_rate = sys_getsr(); > > But more objects in ggee have the same issue. Maybe the author had a > good reason for this... > > A patch to fix them all is easy to make and add to sourceforge.
thanks for your efforts. have you tested this in a subpatch that uses re-sampling (and/or overlap)? afaik, the *proper* way to get the samplerate for oscillators is to use the `s_sr` member of the signal-struct: "sp[0]->s_sr" at least this is how it is done in all Pd-internal oscillators, and i guess it would make sense to have this behaviour be consistent across all oscillators (whether internal or external). fgams IOhannes
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
