Aleksander Morgado wrote:
Hi,
Did you have any more commentary on the time module fixes I added? I
think Jose is waiting on your blessing (hehe ;)) before commiting the
change.
Truth be told, I didn't have time to check them. Anyway, I think those
changes can be commited, and then when the unit tests for the Time
Module are included we'll know if they behave correctly or not.
Cheers,
-Aleksander
Agreed. The main thing is that the unit tests just have to reflect the style of
the time recorded.
To me it makes sense to note times that are West of GMT as negative and times
that are East of GMT as positive offsets. The struct tm does this for us so
thats good.
Before we were just getting the offset regardless of DST which is kind of
pointless if the DST value is set. Then the program would think that when X
country is on DST, their offset is Y even though it should be Z while on DST.
-Zac
