Hi,
I'm investigating the test failures that I'm seeing on an AMD64 box, Fedora 9.
list
text
hash
crypt
error
fp
token
are all OK. I'm getting problems with types, stm and time.
I'll split the issues up into separate mails.
Start with types. It appears to have one issue:
base/types/pdf-i64-div.c:168:E:pdf_i64_div:pdf_i64_div_005:0: (after this
point) Received signal 11 (Segmentation fault)
I'm pretty confident that there is a buffer overflow, but I have no ideas
what the fix is.
I added an assert that triggers on the problem, but don't have a real
fix.
--- src/base/pdf-types.c 2009-03-03 22:26:28 +0000
+++ src/base/pdf-types.c 2009-06-13 08:27:12 +0000
@@ -26,6 +26,7 @@
#include <pdf-types.h>
#include <pdf-alloc.h>
+#include <assert.h>
#ifndef PDF_USE_BUILTIN_64BIT_SUPPORT
@@ -766,6 +767,7 @@
pdf_i64_subtraction(&temp, temp, v_pdf, p_status);
/*We finally put q_bar in the results array*/
+ assert (j < (sizeof(q)/sizeof(q[0])));
q[j] = q_bar;
/*If the remainder is less than zero then we re-add the divisor and
subtract one from q
Step D6*/
Anyone understand what is actually going wrong?
Brad
