Hi Albert.
    
    Please find attached another patch with your suggested modifications
    (pdf_uuid_t is no longer allocated in the heap).

Looks good.

Just one question.  In the function pdf_uuid_string:

   +const char *
   +pdf_uuid_string (pdf_uuid_t uuid)
   +{
   +  static char ascii_rep[PDF_UUID_CHAR_LENGTH];
   +
   +  uuid_unparse (uuid.uuid, ascii_rep);
   +
   +  return ascii_rep;
   +}

Is there a specific reason to use the static buffer 'ascii_rep' instead
of allocating a new string?  That makes pdf_uuid_string non-reentrant.


Reply via email to