On 15.08.2008 13:37:51 Kenneth D Weinert wrote: > > Jeremias Maerki wrote: > > Thanks a lot, Ken! I've applied your patch with small > > modifications. I skipped adding the two license files to the > > website as I found the files in the "licenses" directory and > > there's less redundancy if we just link to the SVN repository. I > > hope you approve. > No problem, it works for me. > > > > http://svn.apache.org/viewvc?rev=686163&view=rev > > > > You might have missed a detail in my replies: Would you please > > attach your future patches to a new JIRA issue? JIRA is better > > suited to explicitely state your intention of making a contribution > > (see the "Attachment license" option when you attach stuff) and to > > track the status of the patch. > Sorry about that - I had the impression I needed to submit the ICLA > first. I've signed up to JIRA now and will submit future patches > through there.
The ICLA is only required for substantial contributions. My mentioning it was a precautionary measure. I consider a few fixes in some documentation to be covered under section 5 of the ALv2. It's something else if you start writing new features for PDFBox. > Just out of curiosity, was there something aside from the license > files that I should have done differently? After all, submitting > patches isn't supposed to make more work for you :) What you did was just fine. Processing patches is always work but you do it for the project and in the hope of recruiting new future committers. I know there are a lot of little things that a new contributor has to learn when he's starting so there's nothing wrong if something takes another round-trip or so. Anyway, I think we've had a good kick-off here. Keep them patches coming! :-) > Thanks. > > > - -- > Ken Weinert > http://quarter-flash.com Jeremias Maerki
