On Wed, Apr 15, 2009 at 11:41 PM, Niall Pemberton
<[email protected]> wrote:
> On Wed, Apr 15, 2009 at 2:51 PM, Jukka Zitting <[email protected]> 
> wrote:
>> Hi,
>>
>> 2009/4/13 Andreas Lehmkühler <[email protected]>:
>>> Please vote on releasing this package as Apache FontBox
>>> 0.8.0-incubating.
>>
>>  [x] +1 Release this package as Apache FontBox 0.8.0-incubating
>>
>> Nice work for a first Apache release!
>>
>> Some issues in addition to what Jeremias already pointed out:
>>
>> * Source jar expands to current directory, not to fontbox-0.8.0
>> * Source jar contains a MANIFEST directory
>> * Source jar contains extra stuff in website/build
>> * Source jar does not contain the Resources and lib directories from svn
>>
>> It's a good practice to start with a clean svn export when doing a release:
>>
>>    svn export http://svn.apache.org/repos/asf/$project/tags/$version
>> $project-$version
>>    jar cMf $project-$version-src-jar $project-$version
>
> -1 from me.
>
> The fontbox-0.8.0-incubating.jar is missing the LICENSE/NOTICE/DISCLAIMER 
> files.
>
> Also the issues found by Jukka and Jeremias are enough to warrant
> fixing and rolling another release candidate IMO. The ASF primarily
> distributes source and the fact that the source distro fails to build
> isn't good.
>
> Niall

P.S. I ran a RAT report on the source distro:

http://people.apache.org/~niallp/rat-fontbox-0.8.0.txt

>> BR,
>>
>> Jukka Zitting
>>
>

Reply via email to