Hello, I have been working on two branches in preparation for the next release and they are now ready for review. I'd appreciate your comments on the changes.
--- +87 −640 The first PR <https://github.com/PDLPorters/pdl/pull/78> proposes moving to a standard Changes format so that it is both human readable and readable by tools such as MetaCPAN. Chris Marshall has already agreed on IRC that this needs to be done for the next PDL release. | This is to address #67. | | This allows for the Changes file to be parsed on MetaCPAN by <https://metacpan.org/pod/CPAN::Changes>. --- +1,578 −1,513 The second PR <https://github.com/PDLPorters/pdl/pull/109> completes the items in the TODO list that called for refactoring all tests to use Test::More. I have also completed a number of other cleanups as can be seen in the PR description: | * using `Test::More` module (no hand-rolled TAP or `Test` module) | * use strict; use warnings everywhere | * remove use of $a, $b lexicals (reserved for `sort` function) | * using Test::Exception (lives_ok, dies_ok, etc.) rather than the `eval { $code }; ok $@` combination | * make each individual test run in its own scope | e.g. | | ```perl | { | my $test = ... | ok( ... ); | } | { | my $test = ... | ok( ... ); | } | ``` | | This makes tests not dependent on previous code which means that they can be | moved around without worrying about state. In the future, these should be setup | as labelled subtests. | * Using `all approx( ... )` instead of a custom `tapprox( ... )` in each file. Cheers, - Zaki Mughal ------------------------------------------------------------------------------ _______________________________________________ pdl-devel mailing list pdl-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pdl-devel
