I had a discussion with Chris last weekend on IRC and we decided that the way forward was to:
First, create a warning for when a comparison op has *_badval ∈ {0, 1}, then merge that into master & do a full release. Then, once that is out, we can change the output type for comparisons to `byte` (testing on a devel branch, as always), see what breaks, & do a dev release. The first of these is done: <https://github.com/PDLPorters/pdl/pull/128>. All the logic fixes that I made while working on the bug are in the same branch as well. I'd really appreciate a code review and then I can go ahead and merge it. You can see that I am testing the warnings in the latest commit (110b7e8). And if it is appropriate, we can merge these changes as well <https://github.com/PDLPorters/pdl/pull/123>. In my opinion, they are safe changes. Cheers, - Zaki ------------------------------------------------------------------------------ _______________________________________________ pdl-devel mailing list pdl-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pdl-devel