On 2016-07-16 at 17:07:53 -0600, Derek Lamb wrote:
> Though I am not too familiar with the constructor code, the fact that it
> passes all tests with all combinations of BADVAL_USENAN and/or BADVAL_PERPDL
> is very encouraging.
>
> finite has been deprecated for quite some time: do you want to use isfinite
> instead? (otherwise I'm going to have to change it when I do another round of
> compiler warning cleanup!)
Hi Derek,
I'm not sure if it is deprecated. It appears to be used as a PDL
compatibility macro around various platforms' floating point
implementations. See `Basic/Core/pdlcore.c.PL` and usage through the
codebase with:
git grep '\(is\)\?finite[[:space:]]*('
.
I agree that `isfinite()` is the modern C99 approach, but I am not sure
if switching to that is the best approach. If it is internal, it really should
also be prefixed with something like `pdl_` or `_pdl_` purely for
namespacing reasons.
Cheers,
- Zaki Mughal
>
> cheers,
> Derek
>
> > On Jul 10, 2016, at 5:50 PM, Zakariyya Mughal <[email protected]> wrote:
> >
> > Hello all,
> >
> > I have a proposed pull request that fixes the remaining cases of the
> > badval configuration <https://github.com/PDLPorters/pdl/pull/190>. I'd
> > like if y'all could review it.
> >
> > One thing to note is that the comparison used for checking badvalues
> > here must also take into consideration NaN, since NAN == NAN is false.
> > Are there any abstractions in the PDL codebase that can help with this
> > "bitwise equality" ( == or !finite(...) ) as opposed to
> > just "numeric equality" (==).
> >
> > I will squash it before merging.
> >
> > Cheers,
> > - Zaki Mughal
> >
> > On 2016-06-27 at 21:53:57 -0600, Craig DeForest wrote:
> >> Aw crud. I will have a look. Thanks!
> >>
> >> (Mobile)
> >>
> >>
> >>> On Jun 27, 2016, at 8:58 PM, Derek Lamb <[email protected]> wrote:
> >>>
> >>> FWIW the commit d12d7b1 "fix skip count for no-badvals case" (which I
> >>> take to be the end of the line on this topic, since it has been merged
> >>> into master) is not passing test t/constructor.t when BADVAL_USENAN
> >>> and/or BADVAL_PER_PDL is true: see
> >>> https://travis-ci.org/PDLPorters/pdl/builds/137405085. Might be worth
> >>> taking a look.
> >>>
> >>> Derek
> >
>
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
pdl-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pdl-devel
