Thank you! I see it's bizarrely failing on the FreeBSD test, which I will look into. As noted on the PR, could you please add tests?
Best regards, Ed ________________________________ From: Jörg Sommrey <j...@sommrey.de> Sent: 14 February 2025 19:16 To: Ed . <ej...@hotmail.com> Cc: pdl-devel@lists.sourceforge.net <pdl-devel@lists.sourceforge.net> Subject: Re: [Pdl-devel] bxorover On Fri 14 Feb 2025 07:34:55 PM CET, "Ed ." <ej...@hotmail.com> wrote: > No reason. Want to PR it? Sure. See https://github.com/PDLPorters/pdl/pull/533 -jo > > Best regards, > Ed > > ________________________________ > From: Jörg Sommrey <j...@sommrey.de> > Sent: 14 February 2025 10:19 > To: pdl-devel@lists.sourceforge.net <pdl-devel@lists.sourceforge.net> > Subject: [Pdl-devel] bxorover > > Hi all, > > is there a specific reason for the absence of 'bxorover'? The patch is > trivial. > > -jo > > diff --git a/lib/PDL/Ufunc.pd b/lib/PDL/Ufunc.pd > index 1adeb636..6dce4d56 100644 > --- a/lib/PDL/Ufunc.pd > +++ b/lib/PDL/Ufunc.pd > @@ -152,6 +152,8 @@ EOF > otype => 'int+', op => 'tmp |= ($a() != 0);', > leftzero => 'tmp' }, > borover => { def=>'$GENERIC() tmp', txt => 'bitwise or', init => 0, > otype => '', op => 'tmp |= $a() ;', leftzero => > '!~tmp' }, > + bxorover => { def=>'$GENERIC() tmp', txt => 'bitwise xor', init => 0, > + otype => '', op => 'tmp ^= $a() ;', leftzero => 0 }, > ); > foreach my $func ( sort keys %over ) { > my $def = $over{$func}{def}; > > > > _______________________________________________ > pdl-devel mailing list > pdl-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/pdl-devel
_______________________________________________ pdl-devel mailing list pdl-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pdl-devel
