Hi, all previously requested CQ’s was already approved. Before I prepare last three (I hope only two), please answer.
Can we drop NIO Async implementation for now? I think for most use cases that we need , classic (blocking) I/O is better. Especially it have proxy support. I can easy reimplement today AsyncDownloader to threaded version (use PoolingHttpClientConnectionManager). -- Dawid Pakuła From: Dawid Pakuła <zu...@w3des.net> <zu...@w3des.net> Reply: Dawid Pakuła <zu...@w3des.net> <zu...@w3des.net> Date: 25 August 2016 at 23:38:56 To: PDT Developers <pdt-dev@eclipse.org> <pdt-dev@eclipse.org> Subject: Re: [pdt-dev] Composer contribution Hi, Composer support merge status update: 1. CQs 1.1. Composer works-with [1] - pending 1.2. GSON 2.2.4 [2] - approved as Orbit PB 1.3. Apache Commons Logging [3] - approved as Orbit PB 1.4. Apache Commons Exec [4] - pending orbit PB 2. Other dependencies 2.1. Apache Common Collections - it’s imported only to use BiDiMap inside RepositoryDialog. I don’t see benefits and want drop this dependency, what yout think? 2.2. Apache Commons IO - it’s imported for FileUtils.copyInputStreamToFile. Schould be easy migrate to java 1.7 Files.copy(). Any objections? 2.3. Appache HttpCore (+NIO) - Orbit already have both bundles but in different wersions, I can prepare PB request, or wait for Orbit update [5] but I don’t know how long it take. So what you think? 2.4. Apache HttpClient - Similar probalem to HttpCore. We can easy reuse old 4.1 or wait for update (btw in my Neon installation I have now three versions of this bundle :P). [1] - http://dev.eclipse.org/ipzilla/show_bug.cgi?id=11873 [2] - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11875 [3] - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11874 [4] - http://dev.eclipse.org/ipzilla/show_bug.cgi?id=11877 [5] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=500270 -- Dawid Pakuła From: Dawid Pakuła <zu...@w3des.net> <zu...@w3des.net> Reply: Dawid Pakuła <zu...@w3des.net> <zu...@w3des.net> Date: 24 August 2016 at 14:42:37 To: PDT Developers <pdt-dev@eclipse.org> <pdt-dev@eclipse.org> Subject: Re: [pdt-dev] Composer contribution Hi, CQ for community plugin is (finally) approved. Before merge I have to prepare some CQ’s for orbit bundles. Did you see any dependency that could be easy droped before merge? As I see Zend depends on jackson, Community plugin reuire a lot of apache commons and apache httpcomponenets + gson and javax. -- Dawid Pakuła From: Thomas Gossmann <ecli...@gos.si> <ecli...@gos.si> Reply: PDT Developers <pdt-dev@eclipse.org> <pdt-dev@eclipse.org> Date: 9 August 2016 at 17:23:04 To: PDT Developers <pdt-dev@eclipse.org> <pdt-dev@eclipse.org> Subject: Re: [pdt-dev] Composer contribution Hey guys, I won't be of any help at the moment, as I'm writing my diploma thesis. If there is something I need to do, please let me know. Anyway, a huge thanks to you guys for moving this forward and giving it some love :) gossi Am 08.08.16 um 12:26 schrieb Michal Niewrzal: > Thanks for info. I didn't notice that IP process in still in progress. > > > Community plugin need some love, but off course can be (and probably > schould be) main plugin. > > Sooner it will be in master, sooner I will be able to give some love 😉 > > Michal > > ------------------------------------------------------------------------ > *Od:* pdt-dev-boun...@eclipse.org <pdt-dev-boun...@eclipse.org> w > imieniu użytkownika Dawid Pakuła <zu...@w3des.net> > *Wysłane:* 8 sierpnia 2016 12:01 > *Do:* PDT Developers > *Temat:* Re: [pdt-dev] Composer contribution > > Hi, > > Community Composer Plugin is still in IPZilla [1]. We are after some > questions so I hope that we receive +1 this week. > After approve and piggy back libs from orbit, can be merged. > Patch is ready to integrate with PDT build system. Things to do: > 1. Add as maven module for PDT parent pom > 2. Modify site.xml > > Later I want populate org.eclipse.php.composer.api plugin to > repo.eclipse.org <http://repo.eclipse.org> > > Community plugin need some love, but off course can be (and probably > schould be) main plugin. > > [1] - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11669 > -- > Dawid Pakuła > > From: Michal Niewrzal <micha...@zend.com> <mailto:micha...@zend.com> > Reply: PDT Developers <pdt-dev@eclipse.org> <mailto:pdt-dev@eclipse.org> > Date: 8 August 2016 at 11:02:46 > To: PDT Developers <pdt-dev@eclipse.org> <mailto:pdt-dev@eclipse.org> > Subject: [pdt-dev] Composer contribution > >> Hi Dawid, >> >> >> What is state of community Composer plugin? Patch is ready to merge or >> we have additional things to do? If we want first version ready for >> Neon.1 we need to start integration. It's how I imagine process: >> >> 1. Merge community plugin to master (can be still in incubation directory) >> >> 2. Add community plugin to build system, mark it as >> experimental/incubation (if you don't have time I can do this) >> >> 3. If we (Zend) will notice something useful in Zend plugin what is >> missing we will merge it with community plugin >> >> 4. Later we can think what we should do with issues reported on github >> for community plugin >> >> >> In general I believe that community plugin will be that main plugin >> and we just move/integrate some features from Zend version of plugin. >> >> What do you think? >> Michal >> >> ------------------------------------------------------------------------ >> *Od:* pdt-dev-boun...@eclipse.org <mailto:pdt-dev-boun...@eclipse.org> >> <pdt-dev-boun...@eclipse.org <mailto:pdt-dev-boun...@eclipse.org>> w >> imieniu użytkownika Michal Niewrzal <micha...@zend.com >> <mailto:micha...@zend.com>> >> *Wysłane:* 5 lipca 2016 11:07 >> *Do:* PDT Developers >> *Temat:* [pdt-dev] Composer contribution >> >> >> Great! Thanks for info >> >> >> ------------------------------------------------------------------------ >> *Od:* pdt-dev-boun...@eclipse.org <mailto:pdt-dev-boun...@eclipse.org> >> <pdt-dev-boun...@eclipse.org <mailto:pdt-dev-boun...@eclipse.org>> w >> imieniu użytkownika Dawid Pakuła <zu...@w3des.net >> <mailto:zu...@w3des.net>> >> *Wysłane:* 5 lipca 2016 10:50 >> *Do:* PDT Developers >> *Temat:* Re: [pdt-dev] Composer contribution >> >> Hi, >> >> I’ll send patch to IP Team during this week. I think its possible to >> have initial support for Neon.1 ;) >> >> -- >> Dawid Pakuła >> >> From: Michal Niewrzal <micha...@zend.com> <mailto:micha...@zend.com> >> Reply: PDT Developers <pdt-dev@eclipse.org> <mailto:pdt-dev@eclipse.org> >> Date: 5 July 2016 at 10:48:58 >> To: PDT Developers <pdt-dev@eclipse.org> <mailto:pdt-dev@eclipse.org> >> Subject: [pdt-dev] Composer contribution >> >>> Hi Dawid, >>> >>> What is the status of moving community Composer to PDT? Do you think >>> its possible to have first version ready for Neon.1? Also if you need >>> help with something just let me know >>> >>> >>> Greetings, >>> >>> Michal >>> >>> >>> ------------------------------------------------------------------------ >>> *Od:* pdt-dev-boun...@eclipse.org >>> <mailto:pdt-dev-boun...@eclipse.org> <pdt-dev-boun...@eclipse.org >>> <mailto:pdt-dev-boun...@eclipse.org>> w imieniu użytkownika Michal >>> Niewrzal <micha...@zend.com <mailto:micha...@zend.com>> >>> *Wysłane:* 26 kwietnia 2016 13:35 >>> *Do:* PDT Developers >>> *Temat:* [pdt-dev] Composer contribution >>> >>> >>> Hi, >>> >>> >>> Yes, I was thinking about place in our gitroot where we can push >>> source code, even without making it visible to the world with update >>> site. Pushed code will be after IP review and it will be easier to >>> manage it. When initial product (like Composer support) will be ready >>> we can add it to category.xml with Incubator/Experimental label. For >>> example I can start and commit Zend Composer plugins. >>> >>> >>> Regarding existing pdt.incubator I also think that we should >>> terminate it. >>> >>> >>> Michal >>> >>> >>> ------------------------------------------------------------------------ >>> *Od:* pdt-dev-boun...@eclipse.org >>> <mailto:pdt-dev-boun...@eclipse.org> <pdt-dev-boun...@eclipse.org >>> <mailto:pdt-dev-boun...@eclipse.org>> w imieniu użytkownika Dawid >>> Pakuła <zu...@w3des.net <mailto:zu...@w3des.net>> >>> *Wysłane:* 25 kwietnia 2016 15:41 >>> *Do:* PDT Developers >>> *Temat:* Re: [pdt-dev] Composer contribution >>> >>> Hi, >>> >>> I think we don’t need incubator as a project, only cons might be in >>> theory parallel ip, so current pdt.incubator probably should be >>> terminated. >>> >>> After IP review we could keep such code inside our gitroot, and >>> inside category.xml mark it as (Incubator) or (Experimental). See how >>> WTP incubate their new components now. >>> >>> -- >>> Dawid Pakuła >>> >>> From: Michal Niewrzal <micha...@zend.com> <mailto:micha...@zend.com> >>> Reply: PDT Developers <pdt-dev@eclipse.org> <mailto:pdt-dev@eclipse.org> >>> Date: 25 April 2016 at 15:16:13 >>> To: PDT Developers <pdt-dev@eclipse.org> <mailto:pdt-dev@eclipse.org> >>> Subject: [pdt-dev] Composer contribution >>> >>>> Hi Dawid, >>>> >>>> >>>> Your plan looks good From our side (Zend) we have green light to >>>> contribute our Composer support to PDT. Maybe we can reopen >>>> Incubator and push code there to have full image. We can think about >>>> things that can be taken from both implementations. For example we >>>> integrated TM Terminal[1] in Console view for colored and >>>> interactive output. Also if there will be problem with IP I can help >>>> reimplement some parts. >>>> >>>> >>>> [1] https://marketplace.eclipse.org/content/tm-terminal >>>> >>>> Michal >>>> <https://marketplace.eclipse.org/content/tm-terminal> >>>> <https://marketplace.eclipse.org/content/tm-terminal> >>>> >>>> TM Terminal | Eclipse Plugins, Bundles and Products ... >>>> <https://marketplace.eclipse.org/content/tm-terminal> >>>> marketplace.eclipse.org <http://marketplace.eclipse.org> >>>> A fully working command-line Terminal inside Eclipse (renamed from >>>> "TCF Terminals"). Just press Ctrl+Alt+T to open a local command >>>> prompt (Terminal). That's all - it ... >>>> >>>> >>>> >>>> >>>> ------------------------------------------------------------------------ >>>> *Od:* pdt-dev-boun...@eclipse.org >>>> <mailto:pdt-dev-boun...@eclipse.org> <pdt-dev-boun...@eclipse.org >>>> <mailto:pdt-dev-boun...@eclipse.org>> w imieniu użytkownika Dawid >>>> Pakuła <zu...@w3des.net <mailto:zu...@w3des.net>> >>>> *Wysłane:* 24 kwietnia 2016 23:37 >>>> *Do:* PDT Developers >>>> *Temat:* [pdt-dev] Composer contribution >>>> >>>> Hi Team, >>>> >>>> I want push forward merging composer support into PDT[1]. I know >>>> thats is not possible to finish before 4.0 but some things may >>>> happen in background: >>>> >>>> 1. Create initial contribution for IP Team. Collecting “approves” >>>> from all contributors might be a challenge. >>>> 2. Library IP cleanup. I switched Composer Binding to gpl simple >>>> json to orbit gson, and made initial patch for WTP JSON Editor >>>> integration. >>>> 3. Synchronization with orbit (pulse00 composer plugin use newest >>>> HTTPTools) >>>> >>>> What you think? >>>> >>>> [1] - https://wiki.eclipse.org/PDT/Composer_Migration >>>> -- >>>> Dawid Pakuła >>>> _______________________________________________ >>>> pdt-dev mailing list >>>> pdt-dev@eclipse.org <mailto:pdt-dev@eclipse.org> >>>> To change your delivery options, retrieve your password, or >>>> unsubscribe from this list, visit >>>> https://dev.eclipse.org/mailman/listinfo/pdt-dev >>> _______________________________________________ >>> pdt-dev mailing list >>> pdt-dev@eclipse.org <mailto:pdt-dev@eclipse.org> >>> To change your delivery options, retrieve your password, or >>> unsubscribe from this list, visit >>> https://dev.eclipse.org/mailman/listinfo/pdt-dev >> _______________________________________________ >> pdt-dev mailing list >> pdt-dev@eclipse.org <mailto:pdt-dev@eclipse.org> >> To change your delivery options, retrieve your password, or >> unsubscribe from this list, visit >> https://dev.eclipse.org/mailman/listinfo/pdt-dev > > > _______________________________________________ > pdt-dev mailing list > pdt-dev@eclipse.org > To change your delivery options, retrieve your password, or unsubscribe from this list, visit > https://dev.eclipse.org/mailman/listinfo/pdt-dev > _______________________________________________ pdt-dev mailing list pdt-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/pdt-dev
_______________________________________________ pdt-dev mailing list pdt-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/pdt-dev
