Hi, So what do you think? Is my extension eligible for PECL?
Vianney. 2015-04-10 17:53 GMT+02:00 Vianney Briois <[email protected]>: > Well i'm not sure translit extension and mine serve the main purpose. With > unidecode, you don't have to know which dialect you get in input, it simply > and quickly convert each non-roman character to its equivalent. When i try > to do the same thing with translit, i can't achieve the same result. > I might not using it well, here is a sample test: > https://gist.github.com/vianneyb/f3c2e6d99006859a607b > > > Vianney. > > 2015-04-10 15:58 GMT+02:00 Johannes Schlüter <[email protected]>: > >> On Fri, 2015-04-10 at 15:23 +0200, Vianney Briois wrote: >> > Hi again, >> > >> > >> > So, i check the transliterator class via the ICU pecl package. It >> > works well on almost every tests i ran. >> > It's quite powerful, but it is slower and does not exactly fulfill my >> > needs. >> > I did check the pecl translit extension before doing mine, and it does >> > not work with the full range of characters i need. (And if you don't >> > provide all parameters, you can have a segfault...) >> >> Are those issues in translit fixable? Or is your version a better >> replacement? - I prefer one well maintained extension over too much >> confusion for users about which to pick :) >> >> If you say they are different enough that's fine and no blocker from me. >> >> > Finally, according to your comments, i removed useless declarations, >> > complied to C88/C90, enhanced the error reporting, and added licence >> > header. >> >> Haven't checked this, yet, but great! >> >> > thx for your time! >> >> Thank you for contributing to PHP! >> >> johannes >> >> >> > > > -- > BRIOIS Vianney > -- BRIOIS Vianney
