Hi, On Mon, 2018-04-30 at 12:48 -0700, Shige Takeda wrote: > Hi Pecl-Dev, > > Could you give me update about PECL account status? > A couple of comments:
- C89 compatibility should be held, unlike here and other places https://github.com/snowflakedb/pdo_snowflake/blob/master/snowflake_driv er.c#L507 https://github.com/snowflakedb/pdo_snowflake/blob/master/snowflake_stmt .c#L578 - C style comments should be used in C sources - libsnowflakeclient and some other binaries are bundled in the repo. It is usually not feasible to redistribute binaries in the PECL packages. Either the libraries available on the system (preferable) are used or sources can be bundled. So far I could check, all the dependencies can be made available externally. - config.w32 seems not implemented. - The readme tells ext/json is a dependency, but there's no check for its presence, neither PHP_ADD_EXTENSION_DEP is used in m4 These are actually minor issues, the only real one is about not bundling any binaries, I guess. Regards Anatol > I will need to push Snowflake PDO in a couple months. > > Thanks, > -- Shige > > On Thu, Mar 29, 2018 at 5:07 PM, Shige Takeda <shige.takeda@snowflake > .net> > wrote: > > > Hello, > > > > My name is Shige Takeda, an engineer at Snowflake Computing, Inc. > > https://www.snowflake.net/ > > > > Currently I have been developing PDO driver for Snowflake DB and > > hosting > > the source code here: > > https://github.com/snowflakedb/pdo_snowflake > > > > Now I would like to publish the PDO driver at PECL repository for > > the > > customers to download. > > > > The license is Apache 2 at the moment as all other drivers have the > > same. > > > > Could you give me a PECL account? > > > > Regards, > > Shige Takeda > > > >
