On Sun, Sep 10, 2023 at 05:04:38PM +0900, Akira Yokosawa wrote:
> ifthen.pdf is tall and using \columnwidth makes it exceed paper
> height in -1c and -eb builds.
>
> .5\onecolumntextwidth (defined in preamble) gives reasonable size
> figures in all layouts.
>
> Signed-off-by: Akira Yokosawa <[email protected]>
> ---
> v1 -> v2:
> Use \onecolumntextwidth for smaller figure in -2c builds.
>
> Paul, this is a minimal change for fixing gitlab-ci error [1].
>
> Figures 15.1 and 15.2 look unnecessarily large in -2c builds.
> I'll tweak those figures as a followup change.
>
> [1]: https://gitlab.com/linux-kernel/perfbook/-/jobs/5052273781
I wouldn't have expected a simple figure to cause so much trouble. ;-)
This approach looks good, so queued and pushed, thank you!
There might be a more general better way to handle the various sizes of
figures and output formats, but all the ones that I could come up with
right off-hand are examples of the cure being worse than the disease.
So full speed ahead, current course and heading! ;-)
Thanx, Paul
> Thanks, Akira
> --
> memorder/memorder.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/memorder/memorder.tex b/memorder/memorder.tex
> index 947e09c9f885..6cf136b8dc6e 100644
> --- a/memorder/memorder.tex
> +++ b/memorder/memorder.tex
> @@ -449,7 +449,7 @@ on
>
> \begin{figure}
> \centering
> -\resizebox{\columnwidth}{!}{\includegraphics{memorder/ifthen}}
> +\resizebox{.5\onecolumntextwidth}{!}{\includegraphics{memorder/ifthen}}
> \caption{If-Then Nature of Memory Ordering}
> \label{fig:memorder:If-Then Nature of Memory Ordering}
> \end{figure}
>
> base-commit: 645f2734592176abc2f1eb87dcd1474b78ba9d2d
> --
> 2.25.1
>
>
