Kevin,

On Tue, May 15, 2007 at 09:13:18PM -0500, Kevin Corry wrote:
> 
> Here are a few short bug-fixes and cleanups for the latest perfmon2 patches.
> 
> 1/6
> >From Anton Blanchard:
> Reserve two TIF flags for perfmon2 and shift them into the low 16 bits
> so we can use single assembly instructions to create constants based off
> them.
> (Anton is talking with Paul Mackerras about getting the two perfmon2 TIF 
> flags 
> reserved for the powerpc architecture.)
> 
Glad you took a look at that. Phil helped me with the first cut. I don't know
if there is something special about the first 16 bits on TIF. I was under the
impression there is something going on on x86_64/i386, but maybe not on PPC.

> 2/6
> The "next available" system call numbers on powerpc changed for the 2.6.21
> kernel.
Sorry about that, I missed that for PPC.

> 
> 3/6
> Remove all trailing whitespace.
> 
> 
> 4/6
> Check the return value from pfm_init_sysfs().  With the integration of 
> kobjects into the perfmon data structures, sysfs is required for normal 
> operation.
> 
> 5/6
> Remove redundant "set->sw_next = NULL" line.
> 
> 6/6
> Add a call to pfm_pmu_conf->unload_context() (if available) to the error path
> in __pfm_load_context().
> 
Thanks for the bug fixes. I will apply all patches to my source tree.

-- 
-Stephane
_______________________________________________
perfmon mailing list
[email protected]
http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/

Reply via email to