Hi Azuma-san,
On Thu August 30 2007 6:00 am, takaki.azuma wrote:
> Hi,
>
> This patch directly accesses the MMIO registers and sets PM signal groups
> for Cell platform.
>
> My previous patch was modified to correspond to git-tree.
> In addition, I changed some coding style and error processing etc.
> (no functional change)
>
> However, "PPE signal group" is included only this time.
>
> I posted the patch to cbe_regs.[ch] (as 3of3).
> However, the patch is posted to PPC/Cell kernel now.
Another thing I've noticed while reviewing these two patches and the one
posted to cbe-oss-dev is that there are several new fields in the MMIO
register data structures that are never used by the new
perfmon_cell_signals.c code. Here's a list:
struct cbe_iic_regs
u64 ioc_dtb_cfg0;
u64 ioc_dtb_cfg3;
struct cbe_mic_tm_regs
u64 mic_ctl_debug2;
u64 mic_ctl_debug_0;
u64 mic_ctl_debug_1;
u64 mic_df_debug_yrac_0;
u64 mic_df_debug_yrac_1;
u64 mic_fir_debug;
u64 tkm_pmcr;
Also, the new cbe_ppe_priv_regs structure contains 7 register fields, but only
two of them (L2_debug1 and ciu_dr1) are used. Is there additional Perfmon
code that you haven't posted yet that uses these registers? If so, will you
be posting it soon? If not, those new register fields should probably be
removed for the time being.
Thanks,
--
Kevin Corry
[EMAIL PROTECTED]
http://www.ibm.com/linux/
_______________________________________________
perfmon mailing list
perfmon@linux.hpl.hp.com
http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/
