Eric, Patch applied. Thanks for your first contribution.
On Fri, Sep 14, 2007 at 04:15:06PM -0400, Eric Paris wrote: > couple places where we are not initializing all of pc and pd to zero in > some of the example programs (task, task_attach, task_attach_timeout) > > How does this list like patches? inline, attached, don't care? does > the list like -p0 -p1 cvsdiff? > > -Eric > > Index: examples/task.c > =================================================================== > RCS file: /cvsroot/perfmon2/libpfm/examples/task.c,v > retrieving revision 1.9 > diff -a -u -p -r1.9 task.c > --- examples/task.c 18 Jun 2007 10:15:12 -0000 1.9 > +++ examples/task.c 14 Sep 2007 20:05:27 -0000 > @@ -91,8 +91,8 @@ parent(char **arg) > pid_t pid; > char name[MAX_EVT_NAME_LEN]; > > - memset(pc, 0, sizeof(ctx)); > - memset(pd, 0, sizeof(ctx)); > + memset(pc, 0, sizeof(pc)); > + memset(pd, 0, sizeof(pd)); > memset(ctx, 0, sizeof(ctx)); > memset(&inp,0, sizeof(inp)); > memset(&outp,0, sizeof(outp)); > Index: examples/task_attach.c > =================================================================== > RCS file: /cvsroot/perfmon2/libpfm/examples/task_attach.c,v > retrieving revision 1.8 > diff -a -u -p -r1.8 task_attach.c > --- examples/task_attach.c 18 Jun 2007 10:15:12 -0000 1.8 > +++ examples/task_attach.c 14 Sep 2007 20:05:27 -0000 > @@ -73,8 +73,8 @@ parent(pid_t pid) > char name[MAX_EVT_NAME_LEN]; > > > - memset(pc, 0, sizeof(ctx)); > - memset(pd, 0, sizeof(ctx)); > + memset(pc, 0, sizeof(pc)); > + memset(pd, 0, sizeof(pd)); > memset(ctx, 0, sizeof(ctx)); > memset(&inp,0, sizeof(inp)); > memset(&outp,0, sizeof(outp)); > Index: examples/task_attach_timeout.c > =================================================================== > RCS file: /cvsroot/perfmon2/libpfm/examples/task_attach_timeout.c,v > retrieving revision 1.8 > diff -a -u -p -r1.8 task_attach_timeout.c > --- examples/task_attach_timeout.c 18 Jun 2007 10:15:12 -0000 1.8 > +++ examples/task_attach_timeout.c 14 Sep 2007 20:05:27 -0000 > @@ -74,8 +74,8 @@ parent(pid_t pid, unsigned long delay) > int ctx_fd; > char name[MAX_EVT_NAME_LEN]; > > - memset(pc, 0, sizeof(ctx)); > - memset(pd, 0, sizeof(ctx)); > + memset(pc, 0, sizeof(pc)); > + memset(pd, 0, sizeof(pd)); > memset(ctx, 0, sizeof(ctx)); > memset(&inp,0, sizeof(inp)); > memset(&outp,0, sizeof(outp)); > > > _______________________________________________ > perfmon mailing list > [email protected] > http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/ -- -Stephane _______________________________________________ perfmon mailing list [email protected] http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/
