Corey, I have applied the patch to CVS. Please try it out and let me know if you find problems.
Thanks for your contributions. On Fri, Oct 12, 2007 at 05:29:03PM -0700, Corey Ashford wrote: > Hi Stephane, > > In a separate email (this time) I will be posting up a new version of > the patch which corrects the errors you found. > > As a result of thinking things through a little more, I decided to > backtrack on a decision I had made to separate out the PowerPC from the > PPC64 implementation. This is at least partially because some of the > include code gets confusing as it's based upon a define of __powerpc__ > which is defined for both 32-bit and 64-bit POWER and PowerPC processors. > > So I've unified the implementation into a single pfmlib_gen_powerpc.c > file. If someone decides to do the engineering required for the 32-bit > processors at some point, perhaps they will be able to make use of what > I've done so far, or maybe they will need to break away from that. But > in the meantime, I've made the guess that the code will be able to be > reused and that the processor-specific differences can be resolved at > runtime. > > This patch also contains a new file in the docs/man3 directory - > libpfm_powerpc.3, containing some info on this implementation. > > One other thing: this implementation obsoletes the file > lib/pfmlib_powerpc.c as it really needed to be renamed to > pfmlib_gen_powerpc.c, so that removal is in the patch file as well. > > - Corey > > -- > Corey Ashford > Software Engineer > IBM Linux Technology Center, Linux Toolchain > Beaverton, OR > 503-578-3507 > [EMAIL PROTECTED] > > _______________________________________________ > perfmon mailing list > [email protected] > http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/ -- -Stephane _______________________________________________ perfmon mailing list [email protected] http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/
