From 921b306c32454056dde04361fdbc59118a644d67 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppi...@redhat.com>
Date: Wed, 27 Jan 2016 08:32:57 +0100
Subject: Modernize spec file
---
.rpmlint | 2 ++
perl-Perl-Critic-Nits.spec | 45 +++++++++++++++++++++++++++++++--------------
2 files changed, 33 insertions(+), 14 deletions(-)
create mode 100644 .rpmlint
diff --git a/.rpmlint b/.rpmlint
new file mode 100644
index 0000000..a22e845
--- /dev/null
+++ b/.rpmlint
@@ -0,0 +1,2 @@
+from Config import *
+addFilter("spelling-error .*
(ProhibitAccessOfPrivateData|ValuesAndExpressions)");
diff --git a/perl-Perl-Critic-Nits.spec b/perl-Perl-Critic-Nits.spec
index 4bb434d..deea307 100644
--- a/perl-Perl-Critic-Nits.spec
+++ b/perl-Perl-Critic-Nits.spec
@@ -1,50 +1,67 @@
Name: perl-Perl-Critic-Nits
Version: 1.0.0
-Release: 12%{?dist}
+Release: 13%{?dist}
Summary: Policies of nits I like to pick
License: GPL+ or Artistic
Group: Development/Libraries
URL: http://search.cpan.org/dist/Perl-Critic-Nits/
Source0:
http://www.cpan.org/authors/id/K/KC/KCOWGILL/Perl-Critic-Nits-v%{version}.tar.gz
BuildArch: noarch
+BuildRequires: coreutils
+BuildRequires: findutils
+BuildRequires: make
+BuildRequires: perl
BuildRequires: perl(ExtUtils::MakeMaker)
-BuildRequires: perl(Perl::Critic) >= 1.07
-# Missing in META.yml
+BuildRequires: perl(strict)
+BuildRequires: perl(warnings)
+# Run-time:
+BuildRequires: perl(base)
+BuildRequires: perl(Perl::Critic::Policy) >= 1.07
+BuildRequires: perl(Perl::Critic::Utils)
BuildRequires: perl(Readonly)
+BuildRequires: perl(strict)
+BuildRequires: perl(version)
+# Tests:
+BuildRequires: perl(File::Find)
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(Perl::Critic::TestUtils)
BuildRequires: perl(Test::More)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
-# Plug-in for perlcritics/Test::More. Require them.
-Requires: perl(Perl::Critic) >= 1.07
-Requires: perl(Test::More)
+# Test::Perl::Critic not used
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires: perl(Perl::Critic::Policy) >= 1.07
+
+# Filter under-specified dependencies
+%global __requires_exclude
%{?__requires_exclude:%{__requires_exclude}|}^perl\\(Perl::Critic::Policy\\)$
%description
-The included policy is:
-Perl::Critic::Policy::ValuesAndExpressions::ProhibitAccessOfPrivateData
-(Prohibits direct access to a hash-based object's hash).
+The included policy is
+Perl::Critic::Policy::ValuesAndExpressions::ProhibitAccessOfPrivateData.
+It prohibits direct access to a hash-based object's hash.
%prep
%setup -q -n Perl-Critic-Nits-v%{version}
%build
-%{__perl} Makefile.PL INSTALLDIRS=perl
+perl Makefile.PL INSTALLDIRS=perl
make %{?_smp_mflags}
%install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
%{_fixperms} $RPM_BUILD_ROOT/*
%check
make test
%files
-%defattr(-,root,root,-)
%doc Changes README
%{perl_privlib}/*
%{_mandir}/man3/*
%changelog
+* Wed Jan 27 2016 Petr Pisar <ppi...@redhat.com> - 1.0.0-13
+- Modernize spec file
+
* Thu Jun 18 2015 Fedora Release Engineering <rel-...@lists.fedoraproject.org>
- 1.0.0-12
- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
--
cgit v0.11.2
http://pkgs.fedoraproject.org/cgit/perl-Perl-Critic-Nits.git/commit/?h=master&id=921b306c32454056dde04361fdbc59118a644d67
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org
