From 18ca101fac99e2efa58ed1fd589d0f5649184ba3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppi...@redhat.com>
Date: Wed, 27 Jan 2016 09:29:41 +0100
Subject: Modernize spec file

---
 .rpmlint                    |  2 ++
 perl-Perl-Critic-Swift.spec | 45 ++++++++++++++++++++++++++-------------------
 2 files changed, 28 insertions(+), 19 deletions(-)
 create mode 100644 .rpmlint

diff --git a/.rpmlint b/.rpmlint
new file mode 100644
index 0000000..90f607b
--- /dev/null
+++ b/.rpmlint
@@ -0,0 +1,2 @@
+from Config import *
+addFilter("spelling-error .* CodeLayout");
diff --git a/perl-Perl-Critic-Swift.spec b/perl-Perl-Critic-Swift.spec
index 9aee2c5..3e6bf79 100644
--- a/perl-Perl-Critic-Swift.spec
+++ b/perl-Perl-Critic-Swift.spec
@@ -1,40 +1,46 @@
 Name:           perl-Perl-Critic-Swift
 Version:        1.0.3
-Release:        15%{?dist}
+Release:        16%{?dist}
 Summary:        Set of additional policies for Perl::Critic
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Perl-Critic-Swift/
 Source0:        
http://www.cpan.org/authors/id/E/EL/ELLIOTJS/Perl-Critic-Swift-v%{version}.tar.gz
 BuildArch:      noarch
-BuildRequires:  perl(List::MoreUtils) >= 0.21
+BuildRequires:  perl
+BuildRequires:  perl(English)
 BuildRequires:  perl(Module::Build)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(utf8)
+BuildRequires:  perl(warnings)
+# Run-time:
+BuildRequires:  perl(base)
+BuildRequires:  perl(List::MoreUtils) >= 0.21
 BuildRequires:  perl(Perl::Critic::Policy) >= 1.082
 BuildRequires:  perl(Perl::Critic::Utils) >= 1.082
 BuildRequires:  perl(version)
-# Non-author tests executed:
-BuildRequires:  perl(English)
+# Tests:
+# Author tests are not executed
+# File::Find not used
+# File::Slurp not used
+BuildRequires:  perl(File::Spec)
 BuildRequires:  perl(Perl::Critic::TestUtils) >= 1.082
+# PPI::Cache not used
+# Test::Distribution not used
+# Test::Kwalitee not used
 BuildRequires:  perl(Test::More)
-# Author tests not executed but included:
-BuildRequires:  perl(File::Spec)
 BuildRequires:  perl(Test::Perl::Critic) >= 1.01
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo 
$version))
+# Test::Pod not used
+# Test::Pod::Coverage not sued
+# Test::Spelling not used
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 Requires:       perl(List::MoreUtils) >= 0.21
 Requires:       perl(Perl::Critic::Policy) >= 1.082
 Requires:       perl(Perl::Critic::Utils) >= 1.082
 
 # Remove underspecified dependencies
-%filter_from_requires /^perl(List::MoreUtils)\s*$/d
-%filter_from_requires /^perl(Perl::Critic::Policy)\s*$/d
-%filter_from_requires /^perl(Perl::Critic::Utils)\s*$/d
+%global __requires_exclude 
%{?__requires_exclude:%__requires_exclude|}perl\\((List::MoreUtils|Perl::Critic::Policy|Perl::Critic::Utils)\\)*$
 # Export not detected versions: $VERSION = qv('v%%{version}')
-%filter_from_provides s/^\(perl(Perl::Critic::[^=]*)$\)/\1 = %{version}/ 
-%filter_setup
-# RPM 4.9 filter
-%global __requires_exclude 
%{?__requires_exclude:%__requires_exclude|}perl\\(List::MoreUtils\\)\\s*$
-%global __requires_exclude 
%__requires_exclude|perl\\(Perl::Critic::Policy\\)\\s*$
-%global __requires_exclude 
%__requires_exclude|perl\\(Perl::Critic::Utils\\)\\s*$
 %global __provides_exclude 
%{?__provides_exclude:%__provides_exclude|}perl\\(Perl::Critic::[^=]*)$\)/\1 = 
%{version}
 
 %description
@@ -48,24 +54,25 @@ policies are:
 %setup -q -n Perl-Critic-Swift-v%{version}
 
 %build
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
 ./Build
 
 %install
 ./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
 %{_fixperms} $RPM_BUILD_ROOT/*
 
 %check
 ./Build test
 
 %files
-%defattr(-,root,root,-)
 %doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*
 
 %changelog
+* Wed Jan 27 2016 Petr Pisar <ppi...@redhat.com> - 1.0.3-16
+- Modernize spec file
+
 * Thu Jun 18 2015 Fedora Release Engineering <rel-...@lists.fedoraproject.org> 
- 1.0.3-15
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
 
-- 
cgit v0.11.2


        
http://pkgs.fedoraproject.org/cgit/perl-Perl-Critic-Swift.git/commit/?h=master&id=18ca101fac99e2efa58ed1fd589d0f5649184ba3
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

Reply via email to