From 1c8220e72969ad6209329dfe090619ccf133a9af Mon Sep 17 00:00:00 2001
From: Paul Howarth <p...@city-fan.org>
Date: Fri, 5 Aug 2016 16:00:49 +0100
Subject: Spec tidy-up

- Classify buildreqs by usage
- Simplify find command using -delete
- Drop %defattr, redundant since rpm 4.4
---
 perl-Sendmail-PMilter.spec | 40 ++++++++++++++++++++++++++++++----------
 1 file changed, 30 insertions(+), 10 deletions(-)

diff --git a/perl-Sendmail-PMilter.spec b/perl-Sendmail-PMilter.spec
index c34dcb4..531d479 100644
--- a/perl-Sendmail-PMilter.spec
+++ b/perl-Sendmail-PMilter.spec
@@ -1,7 +1,7 @@
 Summary:       Perl binding of Sendmail Milter protocol
 Name:          perl-Sendmail-PMilter
 Version:       1.00
-Release:       16%{?dist}
+Release:       17%{?dist}
 License:       BSD
 Group:         Development/Libraries
 URL:           http://search.cpan.org/dist/Sendmail-PMilter/
@@ -14,30 +14,46 @@ Patch4:             Sendmail-PMilter-1.00-sigchld.patch
 Patch5:                Sendmail-PMilter-1.00-protocol.patch
 BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:     noarch
+# Module Build
+BuildRequires: coreutils
+BuildRequires: findutils
+BuildRequires: make
+BuildRequires: perl
 BuildRequires: perl-generators
+BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: sed
+# Module Runtime
 BuildRequires: perl(base)
 BuildRequires: perl(Carp)
 BuildRequires: perl(constant)
-BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(Errno)
+BuildRequires: perl(Exporter)
 BuildRequires: perl(IO::Select)
 BuildRequires: perl(IO::Socket::INET)
 BuildRequires: perl(IO::Socket::INET6)
 BuildRequires: perl(IO::Socket::UNIX)
+BuildRequires: perl(POSIX)
 BuildRequires: perl(Socket)
 BuildRequires: perl(Socket6)
-BuildRequires: perl(Test::More)
+BuildRequires: perl(strict)
+BuildRequires: perl(Symbol)
+BuildRequires: perl(Thread::Semaphore)
 BuildRequires: perl(threads)
 BuildRequires: perl(threads::shared)
-BuildRequires: perl(Thread::Semaphore)
 BuildRequires: perl(Time::HiRes)
+BuildRequires: perl(UNIVERSAL)
+BuildRequires: perl(warnings)
+# Test Suite
+BuildRequires: perl(Test::More)
+# Dependencies
 Requires:      perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 Requires:      perl(IO::Socket::INET)
 Requires:      perl(IO::Socket::INET6)
 Requires:      perl(IO::Socket::UNIX)
 Requires:      perl(Socket6)
+Requires:      perl(Thread::Semaphore)
 Requires:      perl(threads)
 Requires:      perl(threads::shared)
-Requires:      perl(Thread::Semaphore)
 Obsoletes:     perl-Sendmail-Milter <= 0.18
 
 %description
@@ -87,7 +103,7 @@ make %{?_smp_mflags}
 %install
 rm -rf %{buildroot}
 make pure_install DESTDIR=%{buildroot}
-find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+find %{buildroot} -type f -name .packlist -delete
 %{_fixperms} %{buildroot}
 
 %check
@@ -97,14 +113,18 @@ make test
 rm -rf %{buildroot}
 
 %files
-%defattr(-,root,root,-)
 %doc Changes README doc/milter-protocol.txt examples/
 %{perl_vendorlib}/Sendmail/
-%{_mandir}/man3/Sendmail::Milter.3pm*
-%{_mandir}/man3/Sendmail::PMilter.3pm*
-%{_mandir}/man3/Sendmail::PMilter::Context.3pm*
+%{_mandir}/man3/Sendmail::Milter.3*
+%{_mandir}/man3/Sendmail::PMilter.3*
+%{_mandir}/man3/Sendmail::PMilter::Context.3*
 
 %changelog
+* Fri Aug  5 2016 Paul Howarth <p...@city-fan.org> - 1.00-17
+- Classify buildreqs by usage
+- Simplify find command using -delete
+- Drop %%defattr, redundant since rpm 4.4
+
 * Mon May 16 2016 Jitka Plesnikova <jples...@redhat.com> - 1.00-16
 - Perl 5.24 rebuild
 
-- 
cgit v0.12


        
http://pkgs.fedoraproject.org/cgit/perl-Sendmail-PMilter.git/commit/?h=master&id=1c8220e72969ad6209329dfe090619ccf133a9af
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

Reply via email to