From bfca306e965b5869f6e4c927d8d0054dabe5656a Mon Sep 17 00:00:00 2001
From: Paul Howarth <p...@city-fan.org>
Date: Sat, 24 Jun 2017 19:52:52 +0100
Subject: Modernize spec

- Use %license where possible
- Simplify find command using -delete
- No need to remove empty directories from the buildroot
- Drop EOL EPEL distribution support
  - Drop %defattr, redundant since rpm 4.4
  - Drop BuildRoot: and Group: tags
  - Drop explicit buildroot cleaning in %install section
  - Drop explicit %clean section
---
 perl-Crypt-RSA.spec | 63 ++++++++++++++++++++++++++++++-----------------------
 1 file changed, 36 insertions(+), 27 deletions(-)

diff --git a/perl-Crypt-RSA.spec b/perl-Crypt-RSA.spec
index 00c94d4..fb6ea32 100644
--- a/perl-Crypt-RSA.spec
+++ b/perl-Crypt-RSA.spec
@@ -1,14 +1,12 @@
 Summary:       RSA public-key cryptosystem
 Name:          perl-Crypt-RSA
 Version:       1.99
-Release:       21%{?dist}
+Release:       22%{?dist}
 License:       GPL+ or Artistic
-Group:         Development/Libraries
-Url:           http://search.cpan.org/dist/Crypt-RSA/
+URL:           http://search.cpan.org/dist/Crypt-RSA/
 Source0:       
http://search.cpan.org/CPAN/authors/id/V/VI/VIPUL/Crypt-RSA-%{version}.tar.gz
 Patch0:                Crypt-RSA-1.99-utf8.patch
 Patch1:                
Crypt-RSA-1.99-Fix-building-on-Perl-without-dot-in-INC.patch
-BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:     noarch
 BuildRequires: coreutils
 BuildRequires: findutils
@@ -63,6 +61,8 @@ standard, it also provides PKCS #1 v1.5 encryption and 
signatures.
 
 # Convert documentation to UTF-8
 %patch0 -p1
+
+# Fix building on Perls without '.' in @INC
 %patch1 -p1
 
 %build
@@ -70,11 +70,9 @@ perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
-rm -rf %{buildroot}
 make pure_install DESTDIR=%{buildroot}
-find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
-%{_fixperms} %{buildroot}
+find %{buildroot} -type f -name .packlist -delete
+%{_fixperms} -c %{buildroot}
 
 # Additional manpages
 pod2man --section=3 extradocs/crypt-rsa-interoperablity.pod \
@@ -85,31 +83,42 @@ pod2man --section=3 
extradocs/crypt-rsa-interoperablity-template.pod \
 %check
 make test
 
-%clean
-rm -rf %{buildroot}
-
 %files
-%defattr(-,root,root,-)
-%doc ARTISTIC Changes COPYING README TODO
+%if 0%{?_licensedir:1}
+%license ARTISTIC COPYING
+%else
+%doc ARTISTIC COPYING
+%endif
+%doc Changes README TODO
 %{perl_vendorlib}/Crypt/
-%{_mandir}/man3/Crypt::RSA.3pm*
-%{_mandir}/man3/Crypt::RSA::DataFormat.3pm*
-%{_mandir}/man3/Crypt::RSA::Debug.3pm*
-%{_mandir}/man3/Crypt::RSA::ES::OAEP.3pm*
-%{_mandir}/man3/Crypt::RSA::ES::PKCS1v15.3pm*
-%{_mandir}/man3/Crypt::RSA::Errorhandler.3pm*
-%{_mandir}/man3/Crypt::RSA::Key.3pm*
-%{_mandir}/man3/Crypt::RSA::Key::Private.3pm*
-%{_mandir}/man3/Crypt::RSA::Key::Private::SSH.3pm*
-%{_mandir}/man3/Crypt::RSA::Key::Public.3pm*
-%{_mandir}/man3/Crypt::RSA::Key::Public::SSH.3pm*
-%{_mandir}/man3/Crypt::RSA::Primitives.3pm*
-%{_mandir}/man3/Crypt::RSA::SS::PKCS1v15.3pm*
-%{_mandir}/man3/Crypt::RSA::SS::PSS.3pm*
+%{_mandir}/man3/Crypt::RSA.3*
+%{_mandir}/man3/Crypt::RSA::DataFormat.3*
+%{_mandir}/man3/Crypt::RSA::Debug.3*
+%{_mandir}/man3/Crypt::RSA::ES::OAEP.3*
+%{_mandir}/man3/Crypt::RSA::ES::PKCS1v15.3*
+%{_mandir}/man3/Crypt::RSA::Errorhandler.3*
+%{_mandir}/man3/Crypt::RSA::Key.3*
+%{_mandir}/man3/Crypt::RSA::Key::Private.3*
+%{_mandir}/man3/Crypt::RSA::Key::Private::SSH.3*
+%{_mandir}/man3/Crypt::RSA::Key::Public.3*
+%{_mandir}/man3/Crypt::RSA::Key::Public::SSH.3*
+%{_mandir}/man3/Crypt::RSA::Primitives.3*
+%{_mandir}/man3/Crypt::RSA::SS::PKCS1v15.3*
+%{_mandir}/man3/Crypt::RSA::SS::PSS.3*
 %{_mandir}/man3/crypt-rsa-interoperablity.3*
 %{_mandir}/man3/crypt-rsa-interoperablity-template.3*
 
 %changelog
+* Sat Jun 24 2017 Paul Howarth <p...@city-fan.org> - 1.99-22
+- Use %%license where possible
+- Simplify find command using -delete
+- No need to remove empty directories from the buildroot
+- Drop EOL EPEL distribution support
+  - Drop %%defattr, redundant since rpm 4.4
+  - Drop BuildRoot: and Group: tags
+  - Drop explicit buildroot cleaning in %%install section
+  - Drop explicit %%clean section
+
 * Tue May 16 2017 Jitka Plesnikova <jples...@redhat.com> - 1.99-21
 - Fix building on Perl without '.' in @INC
 - Specify all dependencies
-- 
cgit v1.1


        
https://src.fedoraproject.org/cgit/perl-Crypt-RSA.git/commit/?h=master&id=bfca306e965b5869f6e4c927d8d0054dabe5656a
_______________________________________________
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org

Reply via email to