https://bugzilla.redhat.com/show_bug.cgi?id=2190167
Petr Pisar <ppi...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ppi...@redhat.com
--- Comment #2 from Petr Pisar <ppi...@redhat.com> ---
"Inline..." means bundling. E.g. a difference in a code of Importer and
Test2::Util::Importer is exactly this:
--- ../../perl-Importer/Importer-0.026/lib/Importer.pm 2020-08-16
23:24:02.000000000 +0200
+++ lib/Test2/Util/Importer.pm 2023-04-27 11:52:45.000000000 +0200
@@ -1,8 +1,8 @@
-package Importer;
+package Test2::Util::Importer;
use strict; no strict 'refs';
use warnings; no warnings 'once';
-our $VERSION = '0.026';
+our $VERSION = '0.000152';
my %SIG_TO_SLOT = (
'&' => 'CODE',
@@ -763,7 +763,7 @@
# their import redefines things.
BEGIN { \${^WARNING_BITS} = \$caller->[9] if defined \$caller->[9] };
#line $caller->[2] "$caller->[1]"
-(*{"$into\\::\$_"} = \$final{\$_}, push \@{\$Importer::IMPORTED{\$into}} =>
\$_) for keys %final;
+(*{"$into\\::\$_"} = \$final{\$_}, push
\@{\$Test2::Util::Importer::IMPORTED{\$into}} => \$_) for keys
%final;
1;
EOT
}
I really recommend unbundling the modules. Otherwise you are going to maintain
the same code on multiple places.
If you are going to continue bundling them, then you have follow Fedora
guidelines on bundling
<https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling>. I.e.
adding "Provides: bundled(Importer) = 0.026".
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2190167
_______________________________________________
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
