https://bugzilla.redhat.com/show_bug.cgi?id=2072968
--- Comment #2 from Michal Josef Spacek <mspa...@redhat.com> ---
@andr...@andreasvoegele.com Hi Andreas, could we update the spec file to the
last version of the module from CPAN?
Review:
Source file is ok
Summary is ok
License need to update license string to "GPL-1.0-or-later OR
Artistic-1.0-Perl". There is new format in SPDX form.
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
> rpm -qp --requires perl-Alien-libmaxminddb-1.006-1.fc39.x86_64.rpm | sort |
> uniq -c | grep -v rpmlib
1 perl(Alien::Base)
1 perl(Alien::libmaxminddb)
1 perl-libs
1 perl(:MODULE_COMPAT_5.36.1)
1 perl(parent)
1 perl(strict)
1 perl(utf8)
1 perl(:VERSION) >= 5.16.0
1 perl(warnings)
1 pkgconfig(libmaxminddb)
We need to remove "Requires: perl(:MODULE_COMPAT_%(eval "`perl
-V:version`"; echo $version))" line from spec file.
> rpm -qp --provides perl-Alien-libmaxminddb-1.006-1.fc39.x86_64.rpm | sort |
> uniq -c
1 perl(Alien::libmaxminddb::Install::Files)
1 perl-Alien-libmaxminddb(x86-64) = 1.006-1.fc39
1 perl(Alien::libmaxminddb) = 1.006
1 perl-Alien-libmaxminddb = 1.006-1.fc39
Rpmlint is ok
btw: If you put spec and srpm files, there is automatic process which helping
review.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2072968
_______________________________________________
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
