I found the behavior a little confusing that mktest.pl will use a default
configuration file if it is passed on the command line the filename of the
configuration file and it cannot open it. This modifies that so that if
a config file is specified and it cannot be opened, then it complains.
Regards,
Blair
"H . Merijn Brand" wrote:
>
> Open for evaluation.
>
> *** Release 1.08
>
> Tue 18 Sep 2001, Merijn
>
> - MANIFEST check
> - missed harness tests (Nick)
> - Added changes for MSVC5 / dmake (Mattia)
> - Several README changes
> - Auto sensing mailer (mailx, sendmail, mail) in that order
> from Makefile.PL
> - Changed subject in mkovz.pl (easier sorting and perusal in
> smokers-reports)
>
> *** Release 1.07
>
> Mon 10 Sep 2001, Merijn
>
> - Matrix entries could be initialized with scalars ?-( (Nick)
> - References to the webresources in README
> - fail on non cd-able $PC in smoke.sh (Will)
>
> *** Release 1.06
>
> Mon 03 Sep 2001, Merijn
>
> - Makefile.PL's thoughts of smoking dir now more safe and robust
> - Added warning in README for --delete effects
> - VERSION now only in Makefile.PL and mkovz.pl (and ChangeLog :)
> - mkovz.pl changed to use mail if mailx not found in PATH
>
> ----------------------- Original Message -----------------------
> From: PAUSE <[EMAIL PROTECTED]>
> To: "H. Merijn Brand" <[EMAIL PROTECTED]>, [EMAIL PROTECTED]
> Date: Tue, 18 Sep 2001 15:12:25 +0200
> Subject: CPAN Upload: H/HM/HMBRAND/Test-Smoke-1.08.tgz
> ----
>
> The URL
>
> http://home.hccnet.nl/h.m.brand/Test-Smoke-1.08.tgz
>
> has entered CPAN as
>
> file: $CPAN/authors/id/H/HM/HMBRAND/Test-Smoke-1.08.tgz
> size: 13252 bytes
> md5: 7323c8b102c377be69424b73a457be94
>
> No action is required on your part
> Request entered by: HMBRAND (H. Merijn Brand)
> Request entered on: Tue, 18 Sep 2001 13:12:10 GMT
> Request completed: Tue, 18 Sep 2001 13:12:25 GMT
>
> Virtually Yours,
> Id: paused,v 1.74 2001/05/20 14:59:52 k Exp k
>
> --------------------- Original Message Ends --------------------
diff -ru ../Test-Smoke-1.08/mktest.pl ./mktest.pl
--- ../Test-Smoke-1.08/mktest.pl Mon Sep 17 09:27:23 2001
+++ ./mktest.pl Sat Sep 22 19:35:47 2001
@@ -25,7 +25,7 @@
"n|norun|dry-run" => \$norun,
"v|verbose:i" => \$verbose, # NYI
) or usage;
-my $config_file = shift || "smoke.cfg";
+my $config_file = shift;
open TTY, ">&STDERR"; select ((select (TTY), $| = 1)[0]);
open STDERR, ">&1"; select ((select (STDERR), $| = 1)[0]);
@@ -45,6 +45,8 @@
return qx($command);
} # run
+sub is_win32 () { $^O eq 'MSWin32' }
+
sub make ($)
{
my $cmd = shift;
@@ -69,7 +71,10 @@
} # ttylog
my @config;
-if (defined $config_file && -s $config_file) {
+unless (defined $config_file) {
+ $config_file = 'smoke.cfg' if -s 'smoke.cfg';
+}
+if (defined $config_file) {
open CONF, "< $config_file" or die "Can't open '$config_file': $!";
my @conf;
my @target;
diff -ru ../Test-Smoke-1.08/smoke.sh ./smoke.sh
--- ../Test-Smoke-1.08/smoke.sh Mon Sep 10 03:57:37 2001
+++ ./smoke.sh Sat Sep 22 19:29:04 2001
@@ -13,7 +13,6 @@
PATH=`pwd`:$PATH
echo "Smoke $PC"
-umask 0
cd $PC || exit 1
make -i distclean > /dev/null 2>&1
