On Sat, 08 Dec 2001 12:04:27 -0700, Richard Clamp wrote:
> Does it look like I'm heading down the right road with this? If so let me
> know and I'll submit it to p5p for applying to blead.
+BEGIN {
+ chdir 't' if -d 't';
+
+ if ( $ENV{PERL_CORE} ) {
+ @INC = '../lib';
+ }
+}
When I was writing tests for libnet, Graham recommended not to chdir() into 't'
for testing outside of the core. I'd probably move that inside the if block.
+can_ok($t, qw( ReadLine readline addhistory IN OUT MinLine
+ findConsole Attribs Features new ));
I'd loop over these:
foreach my $method (qw( ReadLine readline addhistory IN OUT MinLine
findConsole Attribs Features new) ) {
can_ok( $t, $method );
}
It seems easier to find the one failure if each method has a separate test.
(My assumption is that can_ok() does all in the list, looking at the test plan
earlier.)
Neither is a big deal, just stylistic things. Thanks for sending it along!
-- c
