Michael G Schwern wrote:
>
> In One Sentence
> ---------------
>
> All patches to perl must have an associated testing patch.
[...]
A patch test should do a minimum of two things:
(a) prove the existance of the problem *before* the patch.
(b) prove the problem has been fixed *after* the patch - without
breaking anything else.
The mere existance of (a) means that this test will need to be run prior
to the patching.
The enforcement of (b) will require that the person submitting the patch
understand the actual scope of the patch.
eg.
(1) does it patch an affect a single function?
(2) does it patch something internal to Perl which would require
extensive testing of other functions or core modules which perhaps have
some mechanism in place to correct the initial flaw, but would break
after the patch?
While this may require a fairly lengthy test, I think it's both
necessary and may be able to be pared down by calling other existing
tests.
--a-mused
