"beating out" like you beat out a rug.  Constructive, and still has
the satisfying feeling of clubbing something with sticks.

Anyhow, I just had a look inside installhtml and eeewww.  So if
anyone's got some spare time they can do a little refactoring of
installhtml.  Nothing fancy if it's done in small chunks.

Some ideas:

    Remove anachronisms like "for ($i = 0; $i < $#dirs; $i++)"

    See if it's duplicating features of the modern Pod::Html and
    remove them.

    Clean out old, commented code.

    Remove mentions of pod2html (it uses Pod::Html now)

    Turn chains of prints into here-docs.

    The split* functions have to be available somewhere else.

    Use File::Spec where applicable.

    Convert from $opt_* globals to an %Options hash

    Convert the global salad produced by parse_command_line() into
    a single hash.

Pick one, do it, submit the patch.  Avoid dumping out a huge
all-in-one patch.

Once you've done that you can add "Refactoring" to the list of
buzzwords on your resume. :)


-- 

Michael G. Schwern   <[EMAIL PROTECTED]>    http://www.pobox.com/~schwern/
Perl6 Quality Assurance     <[EMAIL PROTECTED]>       Kwalitee Is Job One
We have cornered the market on senselessness and have profited.

Reply via email to