Ni[kt] picking comments:
There's no example code in the SYNOPSIS.
Your example code which uses Test::Symlink should show how to set up the
plan. Namely: use Test::Symlink tests => 2;
I think not verifying that the destination exists is a mistake as probably
the biggest issue with symlinks is the "dangling symlink" problem where you
have set up a symlink to nowhere. I'd say for every case that you want a
dangling symlink there's 100 where you do not. Make symlink_ok() do the
mostest thing (check that $dst exists) and have a dangling_symlink_ok()
function for that one special case you've dug up. Makes the special case
nice and explicit.
It would be nice to see an example of the generated test name.
I think you're using export_to_level() wrong. $self should really be $class
for starters. And the way you're using it symlink_ok() always gets
exported even if the user says "use Test::Symlink ()". You should be passing
it:
$class->export_to_level(1, $class, @_);
except all the test stuff has to be stripped from @_ first like Test::More
does. Reason #9892 why I should get around to providing a canned import
function in Test::Builder.
Its not clear from the docs what the arguments being checked for sanity
means.
--
Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern
Just call me 'Moron Sugar'.
http://www.somethingpositive.net/sp05182002.shtml
