-----BEGIN PGP SIGNED MESSAGE-----

Moin,

On Monday 19 September 2005 11:33, David Landgren wrote:
> Gábor Szabó wrote:
> > What do you think about adding a has_license kwalitee to CPANTS ?
> > Checking if the META.yml has that entry ?
>
> This will penalise all the modules that use ExtUtils::MakeMaker, which,
> last time I looked, does not generate the license metadata, even though
> the module may clearly state the license used in the documentation.
>
> I made a half-hearted attempt at patching EU::MM to provide a LICENSE
> key to WriteMakefile but then Real Life intervened. It did help me get
> an appreciation of what a thankless job the maintenance of EU::MM is,
> though.

I have to agree. I did run out of energy to do this, myself, and resorted 
to stick this (with variations if nec.) into all my Makefile.PLs:

sub MY::metafile {
  package MY;
  my $self = shift;
  if (!eval { require YAML; 1 })
  {
    warn ("YAML not installed, 'make dist' will not override 
'META.yml'.");
    return $self->SUPER::metafile_target(@_);
  };

  my $node = new YAML::Node {};

  $node->{name}                 = $self->{DISTNAME};
  $node->{abstract}             = $self->{ABSTRACT};
  $node->{version}              = $self->{VERSION};
  $node->{version_from}         = $self->{VERSION_FROM};
  $node->{license}              = 'gpl';
  $node->{distribution_type}    = 'module';
  $node->{generated_by}         = "$self->{DISTNAME} version 
$self->{VERSION}";
  $node->{installdirs}          = 'site';
  $node->{requires}             = $self->{PREREQ_PM};

  my $dump = YAML::Dump( $node );

  $dump =~ s/^(.*)$/\t\$(NOECHO) \$(ECHO) "$1" >>META.yml/gm;
  $dump =~ s/>>META\.yml/>META.yml/;

  return "metafile:\n$dump";
}

Needless code duplication, I know, but currently this is easier than to 
try to fix MM myself...

Best wishes,

Tels

- -- 
 Signed on Tue Sep 20 00:02:36 2005 with key 0x93B84C15.
 Visit my photo gallery at http://bloodgate.com/photos/
 PGP key on http://bloodgate.com/tels.asc or per email.

 "Für eine solche Bitratenreduktion muss ich den Transcoder so
 umkonfigurieren, dass er gröbere Quantisierungskoeffizienten für die
 MPEG-Matrizen verwendet, Captain" - "An die Arbeit, Mr. LaForge." --
 Jens Baumeister in http://tinyurl.com/oomb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iQEVAwUBQy82LXcLPEOTuEwVAQF36Qf8CvDA9AnUyq6SUq5TbMLw2lGiy90fz7Pk
okuohCLShutXnK6ZFW3ZTivD6eBbfkZnNy1kz+avXHSEkVhYqVNDwYBq0z8+mqpt
9NqNqu7YxEqAO3g8BU8+rafWnYoD4OskkMcr0hzQQwwOx9L1lXeYMBLs5hKuEauW
GNQ9oGhuGzoyLxhAcfSxIKjmKJGkA8M6okQmMxAY1LmwAwV4eS6R/ll9ZbJBJLGh
Wl3J6v1penvspyp5oYQ3ZaNRlqiPXZrtGU3qGdyet8Xv42u3n4k/EicdoFIGICty
lCgHw6qYvC1aPlKV3bhwDSVKJPqTQT7+9p1nOXOXuxmZ18VTRuVN1w==
=n5uj
-----END PGP SIGNATURE-----

Reply via email to