Fergal Daly wrote:
> But there's nothing here for the author to do so it should not be
> marked TODO.
Sure there is. They now know Fribble works and can once again start relying on
it.
> This should be a skip wrapped in something to test if the installed
> version of Fribble works or not. Otherwise, if $o->fribble starts
> failing because it's genuinely broken, this becomes a false positive
> (which is the worst thing you can have from a test),
I think we're talking about two different ways to accomplish the same thing.
I'm talking about...
TODO: {
local $TODO = 'Fribble.pm is busted';
ok( $o->fribble, 'fribble' );
}
You're (I think) talking about:
SKIP: {
skip "Fribble.pm is busted" unless $o->fribble;
...tests which rely on Fribble.pm working...
}
The former has the potential to alert the author that Fribble.pm has been fixed
once the test unexpectedly succeeds. The latter simply routes around the
problem and the author is not informed of the fix (unless they happen to notice
that the Fribble tests were not skipped).
