On 29 Jan 2007, at 12:57, Michael G Schwern wrote:
EUMM Patch: http://svn.hexten.net/tapx/patches/ExtUtils- MakeMaker-6.31.patch

I couldn't accept this patch to MM. This would lead to MM's environment being littered with PERL_EUMM_USE_FLAVOR_OF_THE_WEEK. And if TAPx::Harness is going to be the guts for Test::Harness anyway there isn't much point.

Indeed. I should have been more explicit about my intentions here. It's offered only as a simple way of injecting TAPx::Harness just now so that people can play with it in a fairly risk free way.

Actually produced the patch so that *I* can play with TAPx::Harness - and thought it might be useful for others in the same way.

Need something a bit more generic. Perhaps make it easier to override the behavior of test_harness()?

Sure - I'm open to suggestions. Do you mean something like this?:

$ export PERL_EUMM_HARNESS_CLASS=TAPx::Harness::Compatible
$ make test

Also fall through logic makes my eyes bleed.  Rather than this...

    if ($ENV{PERL_EUMM_USE_TAPX}) {
        eval "require TAPx::Harness";
        unless ($@) {
            ...TAPx code...
            return;
        }
    }

    # Fallback: use Test::Harness

Do this.

    if( $ENV{PERL_EUMM_USE_TAPX} && eval "require TAPx::Harness" ) {
       ...TAPx code...
    }
    else {
       ...Test::Harness code...
    }

Or if the condition for checking to use TAPx::Harness were more complex you can figure it out beforehand and roll the decision up into $use_tapx.

Yes indeed. But as you say it'd be nicer still to be able to plug in any alternative harness.

--
Andy Armstrong, hexten.net

Reply via email to