Ian Malpass wrote:
I got a failure message from CPAN testers for Pod::Extract::URI for 5.11.0 patch 33001 on Linux 2.6.22-3-amd64 (x86_64-linux-thread-multi-ld)[0]

The failures were where I was testing to see if an arrayref of qr// patterns was the array I was expecting. is_deeply() has heretofore worked perfectly well.

The test line in question is:

   is_deeply( $peu->stop_uris, [ qr/foo/ ] );

And the failure is:

#   Failed test at t/new.t line 42.
#     Structures begin differing at:
#          $got->[0] = (?i-xsm:foo)
#     $expected->[0] = (?-xism:foo)
# Looks like you failed 1 test of 24.

So, is this 5.11 brokenness, is_deeply() brokenness, or are my tests naive (or wrong)?

(?i-xsm:foo) is equivalent to qr/foo/i. (?-xism:foo) is qr/foo/. They are not equivalent.

So it's possible that 5.11 fixed/broke something, but it's inside stop_uris(). There have been issues with how is_deeply() compares regexes in the past (the ordering of the xism operators, for example) but in this case it appears to be working.


--
On error resume stupid

Reply via email to