Aristotle Pagaltzis wrote: > * Ovid <[EMAIL PROTECTED]> [2008-09-08 12:55]: >> In the developer release of Test::Simple, Test::Builder has >> been altered to die if you have any arguments after 'no_plan'. >> This means that some previously passing tests will fail. In >> fact, there are two test programs in Moose 0.57 which have this >> and thus fail to pass: >> >> use Test::More no_plan => 1; >> >> I've recommended that we warn instead of croak as I don't know >> how widespread this problem is > > I tried to use Google CodeSearch, but for some reason all my > regexes that I feed it match all the cases I want to exclude. > > I tried variations on > > use\s+Test::More.*no_plan\s*[')/]\s*[^;] > > but that matches pretty much every `use Test::More` line with > `no_plan` on it ever written, regardless of what follows. > > If anyone can see something that I can’t, please tell me.
Just search for "no_plan => 1". http://www.google.com/codesearch?hl=en&lr=&q=%22no_plan%20%3D%3E%201%22+lang%3Aperl&btnG=Search I was surprised to get a few hundred results, I've only come across this once and that was in commercial code. Because there's so many uses I took Ovid's recommendation and switched it to a warning. Also the extra argument doesn't do any harm and it's quite understandable that you'd think the args follow the normal "config => on_or_off" pattern. -- E: "Would you want to maintain a 5000 line Perl program?" d: "Why would you write a 5000 line program?"
