Hi, > The only quibble I have then, is that when you said you committed my > patch, that opens the door for confusion ... because people saw my patch > on-line. And then, when we coordinate other patches (like the > accelerator keys) there would be surprises in the diffs. > > So, I think it would have been better if you mentioned that you had also > made some improvements to my patch (and possibly explained them then). > > No lasting harm done, but it might have saved Steve some work. And me > some testing time (first applying and testing Steve's patch, and then > backing that out, applying yours, and testing it).
You are right. Now, i notify on this mailing list any patch change before apply on CVS. It's begining so we need coordinate us ;o) > I'll try to isolate my accelerator key bug fixes and improvements, and > feed them to you, as that will get them into the "real" source faster > than otherwise. > > I see Aldo did add me with commit privileges, and it is good to have > several capable of that... sometimes one might be busy like I am now... > I'll try to get CVS set up someday, but maybe not until Jan or Feb... If you can't commit accelerator key change before Jan, you can send me your change and i commit it. > But if you are willing for the role of bug-fix branch patch coordinator, > I'll be quite content to watch, learn, provide patches to you, and be > available as an extra testing resource re: questionable patches (come > Jan or Feb). I don't think only one person apply patch on CVS it's good. I prefer work in team. We just need coordinate us and define some good pratice. Laurent.
