I get the message. What should be used? Looked at all the documentation
that I
have (including my new jeb-doc) and can't find what the alternative is.
Sigh.
see:
http://perl-win32-gui.sourceforge.net/cgi-bin/docs.cgi?doc=reference-options
popstyle, pushstyle is what you want.
On another note, while looking for -style I looked at GUI.xs.
Being loath to comment:
1. GUI.xs uses a conditional ladder to perform a search.
2. On success, GUI.xs executes code in the conditional block.
It occurs to me that there are two operations that need to be performed; 1)
search, 2) some action based on the search. The current approach is the
same
type of approach that was used in GUI-Constants.cpp. That was changed to a
hash, I wonder if this can also be changed (and yeh, I do know about "it's
not
used too often", but the best code is the one to be desired, yes?).
The search consists of two parts:
search, action
Personally, I'm a speed freak - if something can be made faster, I'm all for
it. In my own apps, I'll even go as far as making the code harder to
maintain:) However, there is always functions that aren't worth optimising
because either they are used during initialisation or they are called
infrequently during runtime. I don't know if this is the case in what you've
highlighted. Yes, in principle the best code should be always used, but
would it be worth your time "fixing" this area when it's not broken? I would
say if there is little benefit in terms of performance, your talents are
better used elsewhere.
My intent is not to discourage you, on the contrary, you clearly know what
you are doing, and you will be a great asset to the Win32-GUI project. Your
suggestion may have merit, but you would need to do some testing to see how
long Win32-GUI spends in the area's that you think could be optimised. If
you create some code to do this, and you need other people to run it against
their applications, I'm sure people would help gather the statistics.
Cheers,
jez.
