I've just looked at GUI_Options.cpp again and wonder if the following code is
correct:

  perlcs->cs.style &= perlcs->cs.style ^ (DWORD) SvIV(ST(next_i));

Shouldn't this be something like:

  perlcs->cs.style &= (perlcs->cs.style | (DWORD) SvIV(ST(next_i)))
                                        ^ (DWORD) SvIV(ST(next_i)));

(other formulations are possible)

I don't have the complete picture, but wouldn't the original equation act as a
toggle? If it's off, it get's turned on, if it's on it get's turned off? Is
there some guarantee that the requested removal action actually has been
previously selected?

The inquiring mind.

art

Reply via email to