>There were some unitialized variable warnings, nothing serious. 'make >test' will run perl under the warnings pragma, so 'use warnings' in your >module will help you catch this sort of thing early.
I generally 'use warnings' or use the -w flag in the modules and scripts I've been writing. I didn't notice it was missing. I need to add strict and warnings to CodeData, as well. In modules/package files, is it practice to leave out the shebang (#!perl) line, since the file is not generally executed directly? If so, is that the reason for 'use warnings' vs. -w? > I don't know what editor you use, but .it's been the norm for marc/perl >module folks to not embed tabs in source code for indentation. vim and >emacs both support mapping a tab to spaces when you hit the tab key. I use BBEdit Lite, which has a good global search/replace function. In the future, I'll try to remember to convert the indentation tabs to 4 spaces per tab. Are non-indentation tabs ok? In MARC::Lint::CodeData, I used split on "\t" to split the codes into a hash. Since some codes have or need spaces, splitting on "\s" would probably not work as well. Thank you for your assistance, Bryan Baldus [EMAIL PROTECTED] [EMAIL PROTECTED] http://home.inwave.com/eija
