Change 23128 by [EMAIL PROTECTED] on 2004/07/16 12:16:05
Use VirtualAlloc() more flexibly when using it to mimic UNIX's sbrk().
From: Steve Hay <[EMAIL PROTECTED]>
CC: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
Assumes perl's malloc can now handle non-contiguous memory (believed
to be true).
Does not address threading issues.
"The attached patch (against blead) makes sbrk() initially try to
extend the existing block of memory exactly as it currently does, but
to not fail immediately if it can't -- it now frees up that part of
whatever it had previously reserved+committed which hadn't actually
been used yet, resets all its static variables and basically starts
anew."
Affected files ...
... //depot/perl/win32/win32.c#236 edit
Differences ...
==== //depot/perl/win32/win32.c#236 (text) ====
Index: perl/win32/win32.c
--- perl/win32/win32.c#235~23111~ Thu Jul 15 02:02:36 2004
+++ perl/win32/win32.c Fri Jul 16 05:16:05 2004
@@ -4155,7 +4155,6 @@
static char *reserved = NULL; /* XXX threadead */
static char *brk = NULL; /* XXX threadead */
static DWORD pagesize = 0; /* XXX threadead */
-static DWORD allocsize = 0; /* XXX threadead */
void *
sbrk(ptrdiff_t need)
@@ -4168,28 +4167,34 @@
* call the OS to commit just one page ...
*/
pagesize = info.dwPageSize << 3;
- allocsize = info.dwAllocationGranularity;
}
- /* This scheme fails eventually if request for contiguous
- * block is denied so reserve big blocks - this is only
- * address space not memory ...
- */
if (brk+need >= reserved)
{
- DWORD size = 64*1024*1024;
+ DWORD size = brk+need-reserved;
char *addr;
+ char *prev_committed = NULL;
if (committed && reserved && committed < reserved)
{
/* Commit last of previous chunk cannot span allocations */
addr = (char *)
VirtualAlloc(committed,reserved-committed,MEM_COMMIT,PAGE_READWRITE);
if (addr)
+ {
+ /* Remember where we committed from in case we want to decommit later */
+ prev_committed = committed;
committed = reserved;
+ }
}
/* Reserve some (more) space
+ * Contiguous blocks give us greater efficiency, so reserve big blocks -
+ * this is only address space not memory...
* Note this is a little sneaky, 1st call passes NULL as reserved
* so lets system choose where we start, subsequent calls pass
* the old end address so ask for a contiguous block
*/
+sbrk_reserve:
+ if (size < 64*1024*1024)
+ size = 64*1024*1024;
+ size = ((size + pagesize - 1) / pagesize) * pagesize;
addr = (char *) VirtualAlloc(reserved,size,MEM_RESERVE,PAGE_NOACCESS);
if (addr)
{
@@ -4201,6 +4206,19 @@
if (!brk)
brk = committed;
}
+ else if (reserved)
+ {
+ /* The existing block could not be extended far enough, so decommit
+ * anything that was just committed above and start anew */
+ if (prev_committed)
+ {
+ if (!VirtualFree(prev_committed,reserved-prev_committed,MEM_DECOMMIT))
+ return (void *) -1;
+ }
+ reserved = base = committed = brk = NULL;
+ size = need;
+ goto sbrk_reserve;
+ }
else
{
return (void *) -1;
@@ -4211,11 +4229,12 @@
if (brk > committed)
{
DWORD size = ((brk-committed + pagesize -1)/pagesize) * pagesize;
- char *addr = (char *) VirtualAlloc(committed,size,MEM_COMMIT,PAGE_READWRITE);
+ char *addr;
+ if (committed+size > reserved)
+ size = reserved-committed;
+ addr = (char *) VirtualAlloc(committed,size,MEM_COMMIT,PAGE_READWRITE);
if (addr)
- {
- committed += size;
- }
+ committed += size;
else
return (void *) -1;
}
End of Patch.
