Change 26059 by [EMAIL PROTECTED] on 2005/11/09 10:56:28

        Remove superfluous strlen() from pp_require().

Affected files ...

... //depot/perl/pp_ctl.c#491 edit

Differences ...

==== //depot/perl/pp_ctl.c#491 (text) ====
Index: perl/pp_ctl.c
--- perl/pp_ctl.c#490~26049~    Tue Nov  8 12:43:11 2005
+++ perl/pp_ctl.c       Wed Nov  9 02:56:28 2005
@@ -3313,10 +3313,8 @@
     else
        SETERRNO(0, SS_NORMAL);
 
-    /* FIXME - is name ever assigned to after the SvPVX_const that also set
-       len?  If no, then this strlen() is superfluous.  */
     /* Assume success here to prevent recursive requirement. */
-    len = strlen(name);
+    /* name is never assigned to again, so len is still strlen(name)  */
     /* Check whether a hook in @INC has already filled %INC */
     if (!hook_sv) {
        (void)hv_store(GvHVn(PL_incgv), name, len, 
newSVpv(CopFILE(&PL_compiling),0),0);
End of Patch.

Reply via email to