Change 27756: [PATCH] pp_sys.c: some Coverity findings: NULL guards for format cv

[Nicholas Clark]

Change 27756 by [EMAIL PROTECTED] on 2006/04/10 12:21:34

        Subject: [PATCH] pp_sys.c: some Coverity findings: NULL guards for 
format cv
        From: [EMAIL PROTECTED] (Jarkko Hietaniemi)
        Message-Id: <[EMAIL PROTECTED]>
        Date: Sat,  8 Apr 2006 18:55:41 +0300 (EEST)

Affected files ...

... //depot/perl/pp_sys.c#502 edit
... //depot/perl/t/op/write.t#44 edit

Differences ...

==== //depot/perl/pp_sys.c#502 (text) ====
Index: perl/pp_sys.c
--- perl/pp_sys.c#501~27755~    2006-04-10 04:56:21.000000000 -0700
+++ perl/pp_sys.c       2006-04-10 05:21:34.000000000 -0700
@@ -1374,15 +1374,13 @@
            gv_efullname4(sv, fgv, NULL, FALSE);
            name = SvPV_nolen_const(sv);
            if (name && *name)
-               DIE(aTHX_ "Undefined top format \"%s\" called",name);
+               DIE(aTHX_ "Undefined top format \"%s\" called", name);
+           else
+               DIE(aTHX_ "Undefined top format called");
        }
-       /* why no:
-       else
-           DIE(aTHX_ "Undefined top format called");
-       ?*/
-       if (CvCLONE(cv))
+       if (cv && CvCLONE(cv))
            cv = (CV*)sv_2mortal((SV*)cv_clone(cv));
-       return doform(cv,gv,PL_op);
+       return doform(cv, gv, PL_op);
     }
 
   forget_top:

==== //depot/perl/t/op/write.t#44 (xtext) ====
Index: perl/t/op/write.t
--- perl/t/op/write.t#43~22960~ 2004-06-18 13:18:02.000000000 -0700
+++ perl/t/op/write.t   2006-04-10 05:21:34.000000000 -0700
@@ -597,7 +597,7 @@
        }
     }
     close FROM_CHILD;
-    print + (@data?"not ":""), "ok ", $test++, " - too litle output\n";
+    print + (@data?"not ":""), "ok ", $test++, " - too little output\n";
     exit;
 }
 
End of Patch.