In perl.git, the branch smoke-me/POSIX has been created <http://perl5.git.perl.org/perl.git/commitdiff/2e10fed019555dc491c5fd10e0e884ffc4c73559?hp=0000000000000000000000000000000000000000>
at 2e10fed019555dc491c5fd10e0e884ffc4c73559 (commit) - Log ----------------------------------------------------------------- commit 2e10fed019555dc491c5fd10e0e884ffc4c73559 Author: Aristotle Pagaltzis <pagalt...@gmx.de> Date: Wed Aug 31 22:08:21 2011 +0200 Replace use of AutoLoader in POSIX with a custom compilation deferral scheme. M ext/B/t/concise-xs.t M ext/POSIX/lib/POSIX.pm commit d5339fb101922fea33eba946a6f08a7ea415e38b Author: Nicholas Clark <n...@ccl4.org> Date: Wed Aug 31 20:58:00 2011 +0200 Test the POSIX functions that wrap core builtins. No need to test the 7 tested elsewhere. M MANIFEST A ext/POSIX/t/wrappers.t commit 73fb0f9ff953ebe9633fcc641ba7016bd56439f8 Author: Nicholas Clark <n...@ccl4.org> Date: Wed Aug 31 18:19:34 2011 +0200 Convert the POSIX waitpid tests to Test::More. Explicitly test POSIX::exit(), POSIX::fork(), POSIX::sleep() and POSIX::waitpid(). Use POSIX::_exit() in the child process. M ext/POSIX/t/waitpid.t commit 6a77c236d7c221690e2a5d51bc972108ecc90f0b Author: Nicholas Clark <n...@ccl4.org> Date: Wed Aug 31 18:02:00 2011 +0200 Explicitly test both CORE:: and POSIX:: gmtime and localtime. The POSIX:: versions should be identical to the CORE:: versions, as they are just wrappers. But the wrappers need testing. M ext/POSIX/t/time.t commit 3da0f44dabb8a2d91791cb1ca473a6076087f91c Author: Nicholas Clark <n...@ccl4.org> Date: Wed Aug 31 16:41:12 2011 +0200 Test the diagnostics for usage messages for POSIX wrapper functions. Regularise the 3 inconsistent messages. M MANIFEST M ext/POSIX/lib/POSIX.pm A ext/POSIX/t/usage.t commit 0d9a3185edcf240fe22265bfad4d1a3484c04f1a Author: Nicholas Clark <n...@ccl4.org> Date: Wed Aug 31 15:20:56 2011 +0200 In POSIX, improve the diagnostic for the "use $method" instead. In the error message, name the POSIX function that was called, as well as the suggested replacement method. This rephrasing was in the patch supplied by Aristotle Pagaltzis, but I have retained the existing POSIX use of :: when describing the method, because given two less than great choices, I'm inclined to favour retaining the status quo and one change over two changes. M ext/POSIX/lib/POSIX.pm M ext/POSIX/t/unimplemented.t commit 6fa4d69c7ff0aa09376cd48621b8a580c44a2772 Author: Aristotle Pagaltzis <pagalt...@gmx.de> Date: Wed Aug 31 14:59:57 2011 +0200 In POSIX, drastically simplify the wrappers for "unimplemented" functions. Replace all the subroutines that croak() with a data structure and 8 lines in POSIX::AUTOLOAD(). [By Aristotle Pagaltzis, with some editing by the committer, and most of his message changes applied as a previous commit to split apart improvements from pure refactoring] This commit eliminates the helper functions POSIX::refef() and POSIX::unimpl(), which were not part of the documented API, not exported, and not used in any code outside the core (that is visible to Google codesearch). M ext/POSIX/lib/POSIX.pm M ext/POSIX/lib/POSIX.pod commit 4cb3c3f87776366be625d4c6a0c5d2f7a9f3168d Author: Nicholas Clark <n...@ccl4.org> Date: Wed Aug 31 14:32:47 2011 +0200 The more regular POSIX "unimplemented" diagnostics simplify the tests. M ext/POSIX/t/unimplemented.t commit 47b0b559cf517776541bc579788f233d12a5b98c Author: Nicholas Clark <n...@ccl4.org> Date: Wed Aug 31 13:08:49 2011 +0200 Improvements to the diagnostics for "unimplemented" POSIX functions. Suggested by Aristotle Pagaltzis as part of a larger refactoring. This regularises the text, changing '--use' and ': use' to ', use' to be consistent, provides a message for POSIX::srand(), and adds ' is' to the message for POSIX::bsearch(). Most of the diagnostics have been unchanged since perl 5.000. For some, IO::Handle replaced FileHandle in perl5.003_20 (28757baaaeaa3801). div and ldiv's messages were improved to also mention % in 2003 by commit 7a6ca5fd18d88091. M ext/POSIX/lib/POSIX.pm M ext/POSIX/t/unimplemented.t commit 145b7baf31abc312d14ff6a769aee1cd1e0331f0 Author: Nicholas Clark <n...@ccl4.org> Date: Wed Aug 31 12:13:46 2011 +0200 Test the diagnostics for all POSIX::* functions that are "unimplemented". M MANIFEST A ext/POSIX/t/unimplemented.t commit f4dff8b7a1f79f3233ccadccb9169e5f89ff8a8a Author: Nicholas Clark <n...@ccl4.org> Date: Wed Aug 31 11:32:17 2011 +0200 In ext/POSIX/t/is.t, make better use of Test::More. cmp_ok() will give better diagnostics than ok(). Using skip_all() is terser, and will give better diagnostics. M ext/POSIX/t/is.t ----------------------------------------------------------------------- -- Perl5 Master Repository