In perl.git, the branch smoke-me/ookow has been created
<http://perl5.git.perl.org/perl.git/commitdiff/1eadb487e2e1c7015b1e84a2779dc52231c59538?hp=0000000000000000000000000000000000000000>
at 1eadb487e2e1c7015b1e84a2779dc52231c59538 (commit)
- Log -----------------------------------------------------------------
commit 1eadb487e2e1c7015b1e84a2779dc52231c59538
Author: Father Chrysostomos <[email protected]>
Date: Sun Nov 25 14:04:05 2012 -0800
test_bootstrap.t: Skip PL_sawampersand tests
unless PERL_SAWAMPERSAND is defined.
M t/porting/test_bootstrap.t
commit dc9430fdda180f6b2f3f8cf7507f53231d99d3bb
Author: Father Chrysostomos <[email protected]>
Date: Sun Nov 25 13:58:40 2012 -0800
Fix up Peek.t to account for preceding commits
M ext/Devel-Peek/t/Peek.t
commit 4c866fe489c6fbc0a4ad90c877ba0be48e690ae6
Author: Father Chrysostomos <[email protected]>
Date: Sun Nov 25 13:52:27 2012 -0800
perl.h: Mention PERL_SAWAMPERSAND in perl -V output
M perl.h
commit 87352b69380f900b1475c7f22bd9ee5dd6a9984f
Author: Father Chrysostomos <[email protected]>
Date: Sun Nov 25 12:57:04 2012 -0800
Disable PL_sawampersand
PL_sawampersand actually causes bugs (e.g., perl #4289), because the
behaviour changes. eval '$&' after a match will produce different
results depending on whether $& was seen before the match.
Using copy-on-write for the pre-match copy (preceding patches do that)
alleviates the slowdown caused by mentioning $&. The copy doesnât
happen unless the string is modified after the match. Itâs now a
post- match copy. So we no longer need to do things differently
depending on whether $& has been seen.
PL_sawampersand is now #defined to be equal to what it would be if
every program began with $',$&,$`.
I left the PL_sawampersand code in place, in case this commit proves
immature. Running Configure with -Accflags=PERL_SAWAMPERSAND will
reënable the PL_sawampersand mechanism.
M embedvar.h
M gv.c
M intrpvar.h
M makedef.pl
M perl.c
M perl.h
M regen/embed.pl
M sv.c
commit ab5f8776c12776fa7fdd2de9b9a1d3f50546cb87
Author: Father Chrysostomos <[email protected]>
Date: Wed Nov 21 12:45:33 2012 -0800
Enable PERL_NEW_COPY_ON_WRITE by default
One can disable this with -Accflags=-DPERL_NO_COW.
I am leaving this in for debugging purposes. If it causes no problems
in 5.18, we might remove the defines and enable it unconditionally in
5.20, but then again we might not.
M perl.h
commit 0f7862d4a9c4526e7ccaca2e81185274aa05382c
Author: Father Chrysostomos <[email protected]>
Date: Sun Nov 4 00:07:31 2012 -0700
Allow COW with magical and blessed scalars (among others)
Under PERL_NEW_COPY_ON_WRITE (and I suspect under
PERL_OLD_COPY_ON_WRITE, too, but have not confirmed) it is harmless to
do copy-on-write with a magical or blessed scalar.
Also, under PERL_NEW_COPY_ON_WRITE, it is safe to do copy-on-write
with scalars that have numbers in them as well as strings (though not
under PERL_OLD_COPY_ON_WRITE).
So redefine CAN_COW_MASK under PERL_NEW_COPY_ON_WRITE to be less
restrictive. We still canât do it when the SvOOK hack is in place,
and I donât feel comfortable doing it with regexps, even if it could
be proven feasible (regexps are SVf_FAKE, so that covers them).
Anything SvROK cannot be SvPOK, so obviously we canât COW with that,
but I left SVf_ROK in for good measure.
This change to CAN_COW_MASK affects whether non-cow scalars will be
turned into cows in sv_setsv_flags. It is already possible for exist-
ing cows to become magical, blessed or numeric elsewhere.
Also, we donât need to check the flags on the lhs in sv_setsv_flags,
except for SVf_BREAK. This is similar to ecd5fa70f3, but applies to
another branch just below it.
M sv.c
M sv.h
commit 9c04768288649aaf6614b4b35ba153be658d183b
Author: Father Chrysostomos <[email protected]>
Date: Fri Oct 19 09:52:03 2012 -0700
Min string length for COW
We have two separate length thresholds for when copy-on-write kicks
in, one for when a buffer would have had to be (re)allocated
(SV_COW_THRESHOLD) and another for when there is already a large
enough buffer available (SV_COWBUF_THRESHOLD).
Benchmarking against mktables and against Test.Simpleâs test suite
(see JS::Test::Simple on CPAN) run with WWW::Scripter and JE shows
that 0/1250 is the best combination, at least on 32-bit darwin.
Apparently, copying into an existing buffer is much faster than the
bookkeeping overhead of sv_force_normal_flags (which I see no way to
speed up).
I have defined these conditionally with #ifndef, so that platform-spe-
cific hints can override them with values appropriate to the platform.
Also, refactor things in sv_setsv_flags slightly to avoid using SvLEN
and SvCUR repeatedly.
M sv.c
M sv.h
commit 4d6f95dfb8f011577d6495e38eea0dd84a2a947e
Author: Father Chrysostomos <[email protected]>
Date: Mon Oct 8 00:20:21 2012 -0700
New COW mechanism
This was discussed in ticket #114820.
This new copy-on-write mechanism stores a reference count for the
PV inside the PV itself, at the very end. (I was using SvEND+1
at first, but parts of the regexp engine expect to be able to do
SvCUR_set(sv,0), which causes the wrong byte of the string to be used
as the reference count.) Only 256 SVs can share the same PV this way.
Also, only strings with allocated space after the trailing null can
be used for copy-on-write.
Much of the code is shared with PERL_OLD_COPY_ON_WRITE. The restric-
tion against doing copy-on-write with magical variables has hence been
inherited, though it is not necessary. A future commit will take
care of that.
It is only enabled with -Accflags=-DPERL_NEW_COPY_ON_WRITE.
M dump.c
M embed.fnc
M embed.h
M makedef.pl
M perl.h
M pp_ctl.c
M pp_hot.c
M proto.h
M regcomp.c
M regexec.c
M regexp.h
M sv.c
M sv.h
M utf8.c
commit f7cf3c3967431fb45ec12d38cb3e4df3cf7c59b0
Author: Father Chrysostomos <[email protected]>
Date: Fri Oct 5 13:00:35 2012 -0700
Move a CAN_COW_MASK comment from sv.c to sv.h
It got left behind in ed25273444 when the macro moved.
M sv.c
M sv.h
commit c3963bc89ddb8f082d630c2cec6e30cdca8f3bb9
Author: Father Chrysostomos <[email protected]>
Date: Thu Oct 4 12:45:45 2012 -0700
Missing dependency in XS::APItestâs Makefile
When core_or_not.inc is modified, core.c and notcore.c should
be recompiled.
M ext/XS-APItest/Makefile.PL
-----------------------------------------------------------------------
--
Perl5 Master Repository