In perl.git, the branch smoke-me/threads-shared-stress has been created
<http://perl5.git.perl.org/perl.git/commitdiff/9f28c6384ccf40ab7e158f98d343a59c296c6074?hp=0000000000000000000000000000000000000000>
at 9f28c6384ccf40ab7e158f98d343a59c296c6074 (commit)
- Log -----------------------------------------------------------------
commit 9f28c6384ccf40ab7e158f98d343a59c296c6074
Author: Joel Berger <[email protected]>
Date: Sat Dec 1 10:15:36 2012 -0600
Cwd::fast_abs_path's untaint should allow for multiline directories
This bug was noticed via https://github.com/dagolden/file-chdir/issues/3
and testing has led to this being the cause.
The problem is worse on some platforms (notably cygwin in this case) when
abs_path is implemented by fast_abs_path.
Since File::chdir tests for proper behavior when a directory contains a
newline, this bug then breaks File::chdir (one of my favorites and very useful
xplatform tool).
Yes this should have tests, but since it will involve creating a directory
with a newline, I thought I would do better to leave that to someone with
better knowledge than I.
M dist/Cwd/Cwd.pm
commit 52ee8d0ab0016f47e2280ef34ee0f8e2d7ee2590
Author: Father Chrysostomos <[email protected]>
Date: Sun Dec 2 18:53:23 2012 -0800
[perl #115962] cwd.t: Add test for fast_abs_path in LF dir
M dist/Cwd/t/cwd.t
commit ea5a229a68de4c28f958df96cd57ae768501de7a
Author: Father Chrysostomos <[email protected]>
Date: Sun Dec 2 17:46:24 2012 -0800
Stop /[\i]/ from leaking under fatal warnings
This commit arranges for the regexp and one temporary sv in S_regclass
to be freed in case the âUnrecognized escape \x in character classâ
warning proves fatal.
M regcomp.c
M t/op/svleak.t
commit 7d12ff0f842717c6be578ba6e7e2463a8d27673e
Author: Father Chrysostomos <[email protected]>
Date: Sun Dec 2 17:40:36 2012 -0800
Stop /(?{})+/ from leaking under fatal warnings
This commit arranges for the regexp to be freed in case the âblah blah
blah matches null string many times in regexâ warning proves fatal.
M regcomp.c
M t/op/svleak.t
commit 6e240d0bbb2875825a18bd4f02983684ddfefa5f
Author: Father Chrysostomos <[email protected]>
Date: Sun Dec 2 17:34:44 2012 -0800
Make PL_sawampersand checks conditional on PERL_SAWAMPERSAND
This does not actually make any difference, since PL_sawampersand is
a constant when PERL_SAWAMPERSAND is undefined. It just makes the
code clearer.
M pp_hot.c
commit 77381e15105d6b7991dbe57c5ee42bb4b06dba0f
Author: Father Chrysostomos <[email protected]>
Date: Sun Dec 2 17:27:41 2012 -0800
Stop /(?{})?/ from leaking under fatal warnings
Fatal errors in regexp compilation do SAVEFREESV before croaking, to
make sure the regexp is freed.
Warnings that happen after the sizing pass need to be protected the
same way, in case they are fatal.
This commit arranges for the regexp to be freed in case the âQuanti-
fier unexpected on zero-length expressionâ warning proves fatal.
/(?{})?/ also triggers some others leaks. Before re_op_compile calls
S_study_chunk, it allocates three scalars for study_chunkâs use. Some
of those are freed after the call to study_chunk, while others become
part of the regexp.
I surrounded the allocation and freeing with an ENTER/LEAVE pair,
using SAVEFREESV to free them when there is a croak. So those cases
SvREFCNT_dec was used, it is simply omitted. Those cases where it was
omitted now have SvREFCNT_inc.
One more complication was that sometimes there is a goto between the
ENTER and the LEAVE which restarts the surrounding code. It already=
took those scalars into account, freeing them. But to balance ENTER/
LEAVE pairs properly I had to do a LEAVE just before the goto, and
remove the freeing of the SVs after the goto.
The new name of the macro that uses goto was inspired by
Acme::ButFirst.
M regcomp.c
M t/op/svleak.t
commit a5e7bc5140f5e3ea032317511826fa1cc38ec7fc
Author: Father Chrysostomos <[email protected]>
Date: Fri Nov 30 20:20:19 2012 -0800
Remove use of SAVEDESTRUCTOR_X(clear_re...) from regcomp.c
The purpose of this is to free the regexp when croaking.
SAVEDESTRUCTOR_X calls clear_re on scope exit. clear_re does
ReREFCNT_dec.
It used to be necessary to do it this way before regular expres-
sions were SVs.
Since v5.10.0-145-g84679df, regexps have been SVs, and ReREFCNT_dec is
effectively an alias for SvREFCNT_dec.
There will be one less function call on scope exit when regexp compi-
lation croaks if we use SAVEFREESV instead of SAVEDESTRUCTOR_X.
M regcomp.c
commit 8c9e24c7f6088cb5fe0779c2c11c1fb4ca8ae693
Author: Yves Orton <[email protected]>
Date: Mon Dec 3 11:49:00 2012 +0100
Make it possible to simulate old style one-at-a-time hashing
With a 0 seed and ONE_AT_A_TIME_OLD hashing enabled one can simulate
older perls (with the exception there is no rehashing at play).
This includes a modest tweak to reduce ops per character by comparing
the string pointer to the end of the string, instead of maintaining
a position counter.
M hv.h
commit c1abd561a0a322ca22ba5ef8301a708c37336afb
Author: Craig A. Berry <[email protected]>
Date: Sun Dec 2 15:17:55 2012 -0600
Better escaping of dots in tovmsspec.
When converting a filename with multiple dots to native VMS syntax,
it's necessary to escape all but the last dot with a caret ('^').
We've been doing this for some time, but have been doing it blindly
such that multiple trips through the converter resulted in a
stuttering caret problem (e.g., foo^^^.bar.pl when foo^.bar.pl was
intended).
So create a convenience macro that does the escaping and make it
only escape unescaped instances and also make it check that the
escape doesn't push us off the end of the buffer we are working
on.
Use the new macro in the three most obvious places that it's
applicable. There may be other places that also should use it.
M vms/vms.c
-----------------------------------------------------------------------
--
Perl5 Master Repository